Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESI][Runtime] Building wheels #6759

Merged
merged 2 commits into from Feb 28, 2024
Merged

[ESI][Runtime] Building wheels #6759

merged 2 commits into from Feb 28, 2024

Conversation

teqdruid
Copy link
Contributor

Adds the ability to create Python wheels for the ESI runtime.

@teqdruid teqdruid added the ESI label Feb 27, 2024
mikeurbach
mikeurbach approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but I think the setup looks good. As usual, I'm not a cmake expert...

lib/Dialect/ESI/runtime/pyproject.toml Outdated Show resolved Hide resolved
lib/Dialect/ESI/runtime/setup.py Outdated Show resolved Hide resolved
lib/Dialect/ESI/runtime/setup.py Show resolved Hide resolved
@teqdruid teqdruid merged commit 5950674 into main Feb 28, 2024
4 checks passed
@teqdruid teqdruid deleted the teqdruid/esirt/publish branch February 28, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

Assignees
No one assigned
Labels
ESI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teqdruid @mikeurbach