Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SV] Verify macro reference symbols #6780

Merged
merged 1 commit into from Mar 4, 2024
Merged

[SV] Verify macro reference symbols #6780

merged 1 commit into from Mar 4, 2024

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Mar 4, 2024

Macro references are now fully verified. Passes have been adjusted to emit the correct declarations.

Closes #6779

@nandor nandor requested a review from uenoku March 4, 2024 13:21
@nandor nandor requested a review from dtzSiFive as a code owner March 4, 2024 13:21
@nandor nandor force-pushed the dev/nandor/macro-decl-check branch from 6bdddcb to c21f5bf Compare March 4, 2024 14:41
uenoku
uenoku approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/Conversion/SeqToSV/SeqToSV.cpp Outdated Show resolved Hide resolved
dtzSiFive
dtzSiFive approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this verification and updating everything!

Grep'ing around for these macros I see other users -- e.g., lib/Dialect/Seq/Transforms/HWMemSimImpl.cpp -- should that also add declarations as needed?

Added some comments, please take a look 👍 .

test/Dialect/Seq/firreg.mlir Outdated Show resolved Hide resolved
test/Dialect/Seq/hw-memsim.mlir Show resolved Hide resolved
lib/Conversion/SeqToSV/SeqToSV.cpp Outdated Show resolved Hide resolved
lib/Conversion/SeqToSV/SeqToSV.cpp Show resolved Hide resolved
@nandor nandor force-pushed the dev/nandor/macro-decl-check branch from c21f5bf to 9fc736b Compare March 4, 2024 15:33
@nandor nandor merged commit e8d919f into main Mar 4, 2024
4 checks passed
@nandor nandor deleted the dev/nandor/macro-decl-check branch March 4, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@uenoku uenoku uenoku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SV] Emit macro declarations for all referenced macros
3 participants
@nandor @uenoku @dtzSiFive