Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Add CMake targets to install all CIRCT libraries. #6798

Merged
merged 1 commit into from Mar 8, 2024
Merged

[CMake] Add CMake targets to install all CIRCT libraries. #6798

merged 1 commit into from Mar 8, 2024

Conversation

mikeurbach
Copy link
Contributor

These targets are useful for downstream projects that want to install
all CIRCT libraries. The CMake commands follow how similar targets are
set up in upstream MLIR.

teqdruid
teqdruid approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me... with the usual caveat.

@mikeurbach
Copy link
Contributor Author

with the usual caveat.

😄 yep, I like the ones where it's just copying something that worked for upstream MLIR.

@mikeurbach mikeurbach merged commit 1abb2c6 into main Mar 8, 2024
4 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/install-circt-libraries branch March 8, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teqdruid teqdruid teqdruid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikeurbach @teqdruid