Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMT] Add constant boolean operation #6825

Merged
merged 1 commit into from Mar 17, 2024
Merged

Conversation

maerhart
Copy link
Member

No description provided.

Copy link
Contributor

@TaoBi22 TaoBi22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

let arguments = (ins BoolAttr:$value);
let results = (outs BoolType:$result);
let assemblyFormat = "$value attr-dict";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably at some point want a builder that just take a boolean, but maybe that's already generated (?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same thought, so I checked, and it's actually already auto-generated 👍

Base automatically changed from maerhart-smt-boolean-ops to main March 17, 2024 16:33
@maerhart maerhart merged commit c406400 into main Mar 17, 2024
4 checks passed
@maerhart maerhart deleted the maerhart-smt-bool-const branch March 17, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants