[SMTToLLVM] Add support for most expressions #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Apr 8, 2024
Comment on lines
+890
to
+900
| /// Lower `smt.int.constant` operations to one of the following two Z3 API | ||
| /// function calls depending on whether the storage APInt has a bit-width that | ||
| /// fits in a `uint64_t`. | ||
| /// ``` | ||
| /// Z3_sort Z3_API Z3_mk_int_sort(Z3_context c); | ||
| /// | ||
| /// Z3_ast Z3_API Z3_mk_int64(Z3_context c, int64_t v, Z3_sort ty); | ||
| /// | ||
| /// Z3_ast Z3_API Z3_mk_numeral(Z3_context c, Z3_string numeral, Z3_sort ty); | ||
| /// Z3_ast Z3_API Z3_mk_unary_minus(Z3_context c, Z3_ast arg); | ||
| /// ``` |
Comment on lines
+1036
to
+1041
|
|
||
| #define ADD_ONE_TO_ONE_PATTERN(OP, APINAME, NUM_ARGS) \ | ||
| patterns.add<OneToOneSMTPattern<OP>>(/*NOLINT(bugprone-macro-parentheses)*/ \ | ||
| converter, patterns.getContext(), \ | ||
| globals, options, APINAME, NUM_ARGS); | ||
|
|
There was a problem hiding this comment.
Same comment as in #6902 about potentially making these templated lambdas to avoid a macro.
There was a problem hiding this comment.
AFAIK templated lambdas are a C++20 feature. If there is something similar we can use in C++17, let me know!
maerhart
force-pushed
the
maerhart-smt-to-llvm-0
branch
from
be24767
to
15c4a3e
Compare
maerhart
force-pushed
the
maerhart-smt-to-llvm-1
branch
from
a895710
to
7c8c488
Compare
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the quantifier operations are still missing.