Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OM] Add IsolatedFromAbove to OMClass #7020

Merged
merged 2 commits into from
May 13, 2024
Merged

[OM] Add IsolatedFromAbove to OMClass #7020

merged 2 commits into from
May 13, 2024

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented May 10, 2024 •
edited
Loading

This adds IsolatedFromAbove to OMClassOp and OMClassExternOp. It should make local verification run parallelly.

@uenoku uenoku requested a review from mikeurbach May 10, 2024 14:27
@fabianschuiki fabianschuiki changed the title [OM] Add IsotlateFromAvobe to OMClass [OM] Add IsotlateFromAbove to OMClass May 11, 2024
@fabianschuiki fabianschuiki changed the title [OM] Add IsotlateFromAbove to OMClass [OM] Add IsolatedFromAbove to OMClass May 11, 2024
dtzSiFive
dtzSiFive approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(test fix looks like just need to update source location expected)

@uenoku uenoku merged commit 4a240b9 into main May 13, 2024
4 checks passed
@uenoku uenoku deleted the dev/hidetou/om branch May 13, 2024 06:39
@uenoku
Copy link
Member Author

uenoku commented May 13, 2024

@fabianschuiki thank you for fixing typos ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@mikeurbach mikeurbach Awaiting requested review from mikeurbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uenoku @dtzSiFive