[CIR] Change linkage name from private to cir_private

Prevents clash with MLIR's symbol visibility "private".
llvm · May 13, 2023 · 2ae0230 · 2ae0230
1 parent 55ce197
commit 2ae0230
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/clang/include/clang/CIR/Dialect/IR/CIROps.td b/clang/include/clang/CIR/Dialect/IR/CIROps.td
@@ -1093,9 +1093,10 @@ def Global_WeakODRLinkage :
 // Rename collisions when linking (static functions).
 def Global_InternalLinkage :
   I32EnumAttrCase<"InternalLinkage", 7, "internal">;
-// Like Internal, but omit from symbol table.
+// Like Internal, but omit from symbol table, prefix it with
+// "cir_" to prevent clash with MLIR's symbol "private".
 def Global_PrivateLinkage :
-  I32EnumAttrCase<"PrivateLinkage", 8, "private">;
+  I32EnumAttrCase<"PrivateLinkage", 8, "cir_private">;
 // ExternalWeak linkage description.
 def Global_ExternalWeakLinkage :
   I32EnumAttrCase<"ExternalWeakLinkage", 9, "extern_weak">;

diff --git a/clang/test/CIR/IR/invalid.cir b/clang/test/CIR/IR/invalid.cir
@@ -184,7 +184,7 @@ module {
 // -----
 
 module {
-  cir.global @a = #cir.const_array<[0 : i8, -23 : i8, 33 : i8] : !cir.array<i32 x 3>> // expected-error {{expected string or keyword containing one of the following enum values for attribute 'linkage' [external, available_externally, linkonce, linkonce_odr, weak, weak_odr, internal, private, extern_weak, common]}}
+  cir.global @a = #cir.const_array<[0 : i8, -23 : i8, 33 : i8] : !cir.array<i32 x 3>> // expected-error {{expected string or keyword containing one of the following enum values for attribute 'linkage' [external, available_externally, linkonce, linkonce_odr, weak, weak_odr, internal, cir_private, extern_weak, common]}}
 }
 
 // -----