Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch remaining undesired usages of MLIR's built-in integer type #81

Closed
sitio-couto opened this issue May 24, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sitio-couto
Copy link
Collaborator

sitio-couto commented May 24, 2023

There are still some scenarios where we should be using the custom !cir.int type.

Most of these scenarios derive from the CIRGenBuilder.h helper class:

mlir::Type getInt8Ty() { return typeCache.Int8Ty; }
mlir::Type getInt32Ty() { return typeCache.Int32Ty; }
mlir::Type getInt64Ty() { return typeCache.Int64Ty; }

In some cases, the use of built-in integer types makes sense, like in the alignment attribute:

auto alignIntAttr = CGM.getSize(alignment);

In others, like function pointers, we should probably change to cir.int:

auto vtablePtrTy = builder.getVirtualFnPtrType(/*isVarArg=*/true);

@bcardosolopes bcardosolopes added bug Something isn't working good first issue Good for newcomers labels May 24, 2023
@bcardosolopes bcardosolopes self-assigned this May 25, 2023
@bcardosolopes
Copy link
Member

Working on this one right now since it's blocking me!

lanza pushed a commit to lanza/llvm-project that referenced this issue Feb 8, 2024
eZWALT pushed a commit to eZWALT/clangir that referenced this issue Mar 24, 2024
eZWALT pushed a commit to eZWALT/clangir that referenced this issue Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants