New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch remaining undesired usages of MLIR's built-in integer type #81
Labels
Comments
bcardosolopes
added
bug
Something isn't working
good first issue
Good for newcomers
labels
May 24, 2023
Working on this one right now since it's blocking me! |
lanza
pushed a commit
that referenced
this issue
Jul 6, 2023
lanza
pushed a commit
that referenced
this issue
Oct 27, 2023
lanza
pushed a commit
that referenced
this issue
Dec 20, 2023
lanza
pushed a commit
that referenced
this issue
Jan 29, 2024
lanza
pushed a commit
to lanza/llvm-project
that referenced
this issue
Feb 8, 2024
lanza
pushed a commit
that referenced
this issue
Mar 23, 2024
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this issue
Mar 24, 2024
lanza
pushed a commit
that referenced
this issue
Apr 29, 2024
lanza
pushed a commit
that referenced
this issue
Apr 29, 2024
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this issue
Apr 29, 2024
lanza
pushed a commit
that referenced
this issue
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are still some scenarios where we should be using the custom
!cir.int
type.Most of these scenarios derive from the
CIRGenBuilder.h
helper class:clangir/clang/lib/CIR/CodeGen/CIRGenBuilder.h
Lines 150 to 152 in b24160c
In some cases, the use of built-in integer types makes sense, like in the
alignment
attribute:clangir/clang/lib/CIR/CodeGen/CIRGenExpr.cpp
Line 1888 in b24160c
In others, like function pointers, we should probably change to
cir.int
:clangir/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
Line 596 in b24160c
The text was updated successfully, but these errors were encountered: