[CIR][Lowering] Lower non-global constant arrays #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. [ghstack-poisoned]
sitio-couto
added a commit
that referenced
this pull request
Jul 10, 2023
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: 0a85dde2244aa9e945d320f55b6667add5f9be60 Pull Request resolved: #171
bcardosolopes
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM with comments to address.
Note: This is indeed an interesting difference, if we forget about LLVM and think only about CIR for a moment, we're also not being uniform right now (my fault), given that const_struct attrs are used inline within cir.const and others are going through globals, at some point we need to migrate more.
htyu
reviewed
Jul 14, 2023
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. [ghstack-poisoned]
sitio-couto
added a commit
that referenced
this pull request
Jul 17, 2023
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
sitio-couto
added a commit
that referenced
this pull request
Jul 17, 2023
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
|
@sitio-couto This diff is causing |
|
lanza
pushed a commit
that referenced
this pull request
Oct 27, 2023
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
lanza
pushed a commit
that referenced
this pull request
Dec 20, 2023
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
lanza
pushed a commit
that referenced
this pull request
Jan 29, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
lanza
pushed a commit
to lanza/llvm-project
that referenced
this pull request
Feb 8, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: llvm/clangir#171
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: llvm#171
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: llvm#171
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: #171
pysuxing
pushed a commit
to pysuxing/llvm-project
that referenced
this pull request
Jul 17, 2024
Lowers `cir.const` operations initialized with constant arrays to LLVM const operations. Also adds supports for `#const.array` with string literals. This implementation differs from Clang: it does not create a global for the constant array, nor uses memcpy to initialize the array. Instead, it stores a constant value directly into the stack where it is used. ghstack-source-id: af42e9a89a27360f58657803ea452d890d2f2324 Pull Request resolved: llvm/clangir#171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Lowers
cir.constoperations initialized with constant arrays to LLVMconst operations. Also adds supports for
#const.arraywith stringliterals.
This implementation differs from Clang: it does not create a global for
the constant array, nor uses memcpy to initialize the array. Instead, it
stores a constant value directly into the stack where it is used.