Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][Lowering] Add an empty LoweringPrepare pass #236

Merged
merged 1 commit into from
Aug 15, 2023
Merged

[CIR][Lowering] Add an empty LoweringPrepare pass #236

merged 1 commit into from
Aug 15, 2023

Conversation

htyu
Copy link
Contributor

@htyu htyu commented Aug 15, 2023

This change is a prerequisite of #235

bcardosolopes
bcardosolopes approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM with one minor inline comment and request for change: please already add a test, just to make sure it's hooked up properly in the pipeline (no need to test for any specific output just yet).

clang/lib/CIR/Dialect/Transforms/CMakeLists.txt Outdated Show resolved Hide resolved
@htyu htyu merged commit fb67e4f into llvm:main Aug 15, 2023
@htyu htyu deleted the LoweringPrepare branch August 15, 2023 20:15
lanza pushed a commit that referenced this pull request Oct 27, 2023
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (#236)
6176124 
This change is a prerequisite of
#235
lanza pushed a commit that referenced this pull request Dec 20, 2023
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (#236)
6033b89 
This change is a prerequisite of
#235
lanza pushed a commit that referenced this pull request Jan 29, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (#236)
1088ed2 
This change is a prerequisite of
#235
lanza pushed a commit that referenced this pull request Mar 23, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (#236)
3f0d7ba 
This change is a prerequisite of
#235
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (llvm#236)
5baedbc 
This change is a prerequisite of
llvm#235
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (llvm#236)
ceff653 
This change is a prerequisite of
llvm#235
lanza pushed a commit that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (#236)
b6c8930 
This change is a prerequisite of
#235
lanza pushed a commit that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (#236)
2119819 
This change is a prerequisite of
#235
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (llvm#236)
fa96f80 
This change is a prerequisite of
llvm#235
lanza pushed a commit that referenced this pull request Apr 29, 2024
@htyu @lanza
[CIR][Lowering] Add an empty LoweringPrepare pass (#236)
57aba62 
This change is a prerequisite of
#235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@htyu @bcardosolopes