[CIR] Vector types, comparison operators #432

dkolsen-pgi · 2024-01-31T00:55:11Z

This is part 3 of implementing vector types and vector operations in ClangIR, issue #284.

Create new operation cir.vec.cmp which implements the relational comparison operators (== != < > <= >=) on vector types. A new operation was created rather than reusing cir.cmp because the result is a vector of a signed intergral type, not a bool.

Add CodeGen and Lowering tests for vector comparisons.

Fix the floating-point comparison predicate when lowering to LLVM. To handle NaN values correctly, the comparisons need to be ordered rather than unordered. (Except for !=, which needs to be unordered.) For example, "ueq" was changed to "oeq".

This is part 3 of implementing vector types and vector operations in ClangIR, issue llvm#284. Create new operation `cir.vec.cmp` which implements the relational comparison operators (`== != < > <= >=`) on vector types. A new operation was created rather than reusing `cir.cmp` because the result is a vector of a signed intergral type, not a `bool`. Add CodeGen and Lowering tests for vector comparisons. Fix the floating-point comparison predicate when lowering to LLVM. To handle NaN values correctly, the comparisons need to be ordered rather than unordered. (Except for `!=`, which needs to be unordered.) For example, "ueq" was changed to "oeq".

bcardosolopes

Awesome, and thanks for the neat testcases!

The buildbot failures seems unrelated.

This is part 3 of implementing vector types and vector operations in ClangIR, issue #284. Create new operation `cir.vec.cmp` which implements the relational comparison operators (`== != < > <= >=`) on vector types. A new operation was created rather than reusing `cir.cmp` because the result is a vector of a signed intergral type, not a `bool`. Add CodeGen and Lowering tests for vector comparisons. Fix the floating-point comparison predicate when lowering to LLVM. To handle NaN values correctly, the comparisons need to be ordered rather than unordered. (Except for `!=`, which needs to be unordered.) For example, "ueq" was changed to "oeq".

This is part 3 of implementing vector types and vector operations in ClangIR, issue llvm#284. Create new operation `cir.vec.cmp` which implements the relational comparison operators (`== != < > <= >=`) on vector types. A new operation was created rather than reusing `cir.cmp` because the result is a vector of a signed intergral type, not a `bool`. Add CodeGen and Lowering tests for vector comparisons. Fix the floating-point comparison predicate when lowering to LLVM. To handle NaN values correctly, the comparisons need to be ordered rather than unordered. (Except for `!=`, which needs to be unordered.) For example, "ueq" was changed to "oeq".

This is part 3 of implementing vector types and vector operations in ClangIR, issue #284. Create new operation `cir.vec.cmp` which implements the relational comparison operators (`== != < > <= >=`) on vector types. A new operation was created rather than reusing `cir.cmp` because the result is a vector of a signed intergral type, not a `bool`. Add CodeGen and Lowering tests for vector comparisons. Fix the floating-point comparison predicate when lowering to LLVM. To handle NaN values correctly, the comparisons need to be ordered rather than unordered. (Except for `!=`, which needs to be unordered.) For example, "ueq" was changed to "oeq".

This is part 3 of implementing vector types and vector operations in ClangIR, issue llvm#284. Create new operation `cir.vec.cmp` which implements the relational comparison operators (`== != < > <= >=`) on vector types. A new operation was created rather than reusing `cir.cmp` because the result is a vector of a signed intergral type, not a `bool`. Add CodeGen and Lowering tests for vector comparisons. Fix the floating-point comparison predicate when lowering to LLVM. To handle NaN values correctly, the comparisons need to be ordered rather than unordered. (Except for `!=`, which needs to be unordered.) For example, "ueq" was changed to "oeq".

This is part 3 of implementing vector types and vector operations in ClangIR, issue #284. Create new operation `cir.vec.cmp` which implements the relational comparison operators (`== != < > <= >=`) on vector types. A new operation was created rather than reusing `cir.cmp` because the result is a vector of a signed intergral type, not a `bool`. Add CodeGen and Lowering tests for vector comparisons. Fix the floating-point comparison predicate when lowering to LLVM. To handle NaN values correctly, the comparisons need to be ordered rather than unordered. (Except for `!=`, which needs to be unordered.) For example, "ueq" was changed to "oeq".

dkolsen-pgi mentioned this pull request Jan 31, 2024

[CIR] Vector types, comparison operators #420

Closed

dkolsen-pgi requested a review from bcardosolopes January 31, 2024 00:57

bcardosolopes approved these changes Jan 31, 2024

View reviewed changes

bcardosolopes merged commit f2ac9f5 into llvm:main Jan 31, 2024
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CIR] Vector types, comparison operators #432

[CIR] Vector types, comparison operators #432

dkolsen-pgi commented Jan 31, 2024

bcardosolopes left a comment

[CIR] Vector types, comparison operators #432

[CIR] Vector types, comparison operators #432

Conversation

dkolsen-pgi commented Jan 31, 2024

bcardosolopes left a comment

Choose a reason for hiding this comment