[CIR][Lowering] Support lowering on cir::TernaryOp. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support cir::TernaryOp lowering -cir-to-llvm.
- Mostly mirror the scf.if to cf and cir.if lowerings.
- also support cir.br lowering with type converter, like
the `cir.br ^bb3(%9 : !s32i)` , !s32i is !cir.int<s, 32>.
and this type not supported in LLVM dialect level.
- current generate `builtin.unrealized_conversion_cast` Ops in
tests, will cause the next rountine mlir-translate failed.
Need to consider whether to include ReconcileUnrealizedCasts pass
or find some other methods.
redbopo
force-pushed
the
add_ternary_op_lowering
branch
from
c60071a
to
48964d0
Compare
|
@redbopo LGTM. |
bcardosolopes
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Sorry for the delay, this looks good pending updating #98 to include the fix you mentioned.
|
Replaced with #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cir.br ^bb3(%9 : !s32i), !s32i is !cir.int<s, 32>. and this type not supported in LLVM dialect level.builtin.unrealized_conversion_castOps in tests, will cause the next rountine mlir-translate failed. Need to consider whether to include ReconcileUnrealizedCasts pass or find some other methods.