Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for llvm/llvm-project#57076 #91

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Conversation

llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Aug 11, 2022

mstorsjo and others added 3 commits August 11, 2022 12:31
This adds support for the existing GNU ld command line option, which
allows excluding individual symbols from autoexport (when linking a
DLL and no symbols are marked explicitly as dllexported).

Differential Revision: https://reviews.llvm.org/D130118

(cherry picked from commit d1da646)
The former stores strings and is therefore more expensive.

(cherry picked from commit dfe2a3f)
… -exclude-symbols:

This is an entirely new embedded directive - extending the GNU ld
command line option --exclude-symbols to be usable in embedded
directives too.

(GNU ld.bfd also got support for the same new directive, currently in
the latest git version, after the 2.39 branch.)

This works as an inverse to the regular embedded dllexport directives,
for cases when autoexport of all eligible symbols is performed.

Differential Revision: https://reviews.llvm.org/D130120

(cherry picked from commit 5d513ef)
@llvmbot
Copy link
Collaborator Author

llvmbot commented Aug 11, 2022

@rnk @mstorsjo @MaskRay @rnk @mstorsjo @MaskRay What do you think about merging this PR to the release branch?

@tru
Copy link
Contributor

tru commented Aug 11, 2022

@rnk @mstorsjo @MaskRay @rnk @mstorsjo @MaskRay What do you think about merging this PR to the release branch?

chill llvmbot. that list probably should be just unique users - will see if I can fix that.

@MaskRay
Copy link
Member

MaskRay commented Aug 11, 2022

LGTM

@tru tru merged commit 3b0219a into release/15.x Aug 12, 2022
@tru tru deleted the mstorsjo-lld-exclude-symbols-15.x branch August 12, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport LLD/COFF support for "exclude-symbols" to 15.x
4 participants