Skip to content

Commit

Permalink
[compiler-rt] Create the umbrella check-compiler-rt test target in no…
Browse files Browse the repository at this point in the history
…n-standalone builds too

I don't see why we can't have this target when built as a project alongside
llvm; especially in such build configs, it's useful to have one single target
for running all tests (in standalone builds, check-all does the same too),

Keep the creation of the check-all target only for standalone builds.

Differential Revision: https://reviews.llvm.org/D147646
  • Loading branch information
mstorsjo committed Apr 6, 2023
1 parent b25e989 commit 002897b
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions compiler-rt/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ if(NOT ANDROID)
endif()
endif()

if(COMPILER_RT_STANDALONE_BUILD)
umbrella_lit_testsuite_begin(check-compiler-rt)
endif()
umbrella_lit_testsuite_begin(check-compiler-rt)

function(compiler_rt_test_runtime runtime)
string(TOUPPER ${runtime} runtime_uppercase)
Expand Down Expand Up @@ -110,12 +108,12 @@ if(COMPILER_RT_CAN_EXECUTE_TESTS)
add_subdirectory(shadowcallstack)
endif()

if(COMPILER_RT_STANDALONE_BUILD)
# Now that we've traversed all the directories and know all the lit testsuites,
# introduce a rule to run to run all of them.
add_custom_target(compiler-rt-test-depends DEPENDS ${LLVM_COMPILER_RT_LIT_DEPENDS})
umbrella_lit_testsuite_end(check-compiler-rt)
# Now that we've traversed all the directories and know all the lit testsuites,
# introduce a rule to run to run all of them.
add_custom_target(compiler-rt-test-depends DEPENDS ${LLVM_COMPILER_RT_LIT_DEPENDS})
umbrella_lit_testsuite_end(check-compiler-rt)

if(COMPILER_RT_STANDALONE_BUILD)
if(NOT TARGET check-all)
add_custom_target(check-all)
endif()
Expand Down

0 comments on commit 002897b

Please sign in to comment.