Skip to content

Commit

Permalink
[libc++abi] Remove XFAIL on arm64
Browse files Browse the repository at this point in the history
The underlying TLS destruction order bug has been fixed in the OS. This
would technically still fail when running on top of macOS < 12, however
we don't have a good way of encoding that using Lit features. Indeed,
the existing target=<FOO> Lit feature encodes the deployment target,
not the actual runtime system that the tests are being run on.

If this test starts failing on your machine after this patch, upgrading
to macOS 12 should solve the problem.

(cherry picked from commit dd8269c)
  • Loading branch information
ldionne committed May 10, 2022
1 parent 1f91400 commit 019d4f1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions libcxxabi/test/thread_local_destruction_order.pass.cpp
Expand Up @@ -9,9 +9,6 @@
// UNSUPPORTED: c++03
// UNSUPPORTED: libcxxabi-no-threads

// TODO: Investigate this failure
// XFAIL: target=arm64-apple-{{.+}}

#include <cassert>
#include <thread>

Expand Down

0 comments on commit 019d4f1

Please sign in to comment.