Skip to content

Commit

Permalink
ObjCARC: Try to fix faulty tests
Browse files Browse the repository at this point in the history
These were trying to check if there was not an llvm.objc call before a
closing "}", which presumably was intended to match the end of the
function. Really this was matching the closing } in "bitcast {}* %self
to i8*", which can't be what anyone intended. This broke after
converting the test to opaque pointer deleted this bitcast.

There are in fact @llvm.obj calls remaining in the function, so this
may indicate the transform this was intended to check is actually
broken. In @"\01-[A z]" (great test name), the first retain call seems
to move down to the printf. The second case, @"\01-[Top0 _getX]", has
no change.

Change the checks to what's produced and add FIXMES. Also change the }
checks to match only at the start of the line for the function end.
  • Loading branch information
arsenm committed Dec 13, 2022
1 parent 4f63f97 commit 021ff53
Showing 1 changed file with 145 additions and 139 deletions.

0 comments on commit 021ff53

Please sign in to comment.