Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AArch64][MachineOutliner] Don't outline CFI instructions
CFI instructions can only safely be outlined when the outlined call is a tail call, or when the outlined frame is fixed up. For the sake of correctness, disable outlining from CFI instructions. Add machine-outliner-cfi.mir to test this.
- Loading branch information
Jessica Paquette
committed
Mar 2, 2020
1 parent
e20e6f2
commit 02c154a
Showing
2 changed files
with
71 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py | ||
# RUN: llc -mtriple=aarch64-apple-unknown -run-pass=machine-outliner -verify-machineinstrs %s -o - | FileCheck %s | ||
|
||
# Outlining CFI instructions is unsafe. It is possible if the call is tail | ||
# called, but otherwise, it requires fixups. Show that we don't include CFI | ||
# instructions in outlined sequences right now. | ||
|
||
--- | | ||
define void @foo() #0 { ret void } | ||
define void @bar() #0 { ret void } | ||
define void @baz() #0 { ret void } | ||
attributes #0 = { noredzone } | ||
... | ||
--- | ||
name: foo | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $lr | ||
; CHECK-LABEL: name: foo | ||
; CHECK: liveins: $lr | ||
; CHECK: frame-setup CFI_INSTRUCTION def_cfa $w29, 16 | ||
; CHECK: TCRETURNdi @OUTLINED_FUNCTION_0, 0, implicit $sp, implicit-def $w12, implicit-def $w13, implicit-def $w14, implicit-def $w15 | ||
frame-setup CFI_INSTRUCTION def_cfa $w29, 16 | ||
$w12 = ORRWri $wzr, 1 | ||
$w13 = ORRWri $wzr, 2 | ||
$w14 = ORRWri $wzr, 3 | ||
$w15 = ORRWri $wzr, 4 | ||
RET undef $lr | ||
... | ||
--- | ||
name: bar | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $lr | ||
; CHECK-LABEL: name: bar | ||
; CHECK: liveins: $lr | ||
; CHECK: frame-setup CFI_INSTRUCTION def_cfa $w29, 16 | ||
; CHECK: TCRETURNdi @OUTLINED_FUNCTION_0, 0, implicit $sp, implicit-def $w12, implicit-def $w13, implicit-def $w14, implicit-def $w15 | ||
frame-setup CFI_INSTRUCTION def_cfa $w29, 16 | ||
$w12 = ORRWri $wzr, 1 | ||
$w13 = ORRWri $wzr, 2 | ||
$w14 = ORRWri $wzr, 3 | ||
$w15 = ORRWri $wzr, 4 | ||
RET undef $lr | ||
... | ||
--- | ||
name: baz | ||
tracksRegLiveness: true | ||
body: | | ||
bb.0: | ||
liveins: $lr | ||
; CHECK-LABEL: name: baz | ||
; CHECK: liveins: $lr | ||
; CHECK: frame-setup CFI_INSTRUCTION def_cfa $w29, 16 | ||
; CHECK: TCRETURNdi @OUTLINED_FUNCTION_0, 0, implicit $sp, implicit-def $w12, implicit-def $w13, implicit-def $w14, implicit-def $w15 | ||
frame-setup CFI_INSTRUCTION def_cfa $w29, 16 | ||
$w12 = ORRWri $wzr, 1 | ||
$w13 = ORRWri $wzr, 2 | ||
$w14 = ORRWri $wzr, 3 | ||
$w15 = ORRWri $wzr, 4 | ||
RET undef $lr |