Skip to content

Commit

Permalink
[lld][ELF][test] Fix excessive output file size in loongarch-add-sub.s
Browse files Browse the repository at this point in the history
Initially the .rodata section came before .text, hence sharing its
segment with the program header sitting at a small offset, pushing the
output file size to ~72GiB (the file was sparse though, so not much is
really written). This breaks on 32-bit platforms and is irrelevant to
the feature being tested, so re-order the two sections so .text gets
processed first, and both sections get their own segment.

This addresses the issue found by the clang-armv8-lld-2stage builder:
    https://lab.llvm.org/buildbot/#/builders/178/builds/5340

Reviewed By: SixWeining, xry111

Differential Revision: https://reviews.llvm.org/D156293

(cherry picked from commit ffe2b6f)
  • Loading branch information
xen0n authored and tru committed Jul 27, 2023
1 parent d4a6c50 commit 02ccc2a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions lld/test/ELF/loongarch-add-sub.s
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

# RUN: llvm-mc --filetype=obj --triple=loongarch64-unknown-elf %s -o %t.la64.o

# RUN: ld.lld --section-start=.rodata=0x1234567890 --section-start=.text=0x9876543210 %t.la64.o -o %t.la64
# RUN: ld.lld --section-start=.text=0x1234567890 --section-start=.rodata=0x9876543210 %t.la64.o -o %t.la64
# RUN: llvm-readelf -x .rodata %t.la64 | FileCheck --check-prefix=CHECK %s
# CHECK: section '.rodata':
# CHECK-NEXT: 0x1234567890 10325476 98badcfe 80b9fd41 86000000
# CHECK-NEXT: 0x12345678a0 80b9fd41 80b980
# CHECK-NEXT: 0x9876543210 10325476 98badcfe 804602be 79ffffff
# CHECK-NEXT: 0x9876543220 804602be 804680

.text
.global _start

_start:
1:
break 0
Expand Down

0 comments on commit 02ccc2a

Please sign in to comment.