Skip to content

Commit

Permalink
Silence some MSVC warnings.
Browse files Browse the repository at this point in the history
Summary:
Just `assert("string" && false)` instead of `assert("string" == NULL)`.

This avoid errors like

    [...]\Core\SourceManager.cpp(647): warning C4130: '==' : logical operation on address of string constant

Reviewers: zturner

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D12388

llvm-svn: 246123
  • Loading branch information
sas committed Aug 26, 2015
1 parent b39e44b commit 03439a8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lldb/source/Core/SourceManager.cpp
Expand Up @@ -644,14 +644,14 @@ SourceManager::File::CalculateLineOffsets (uint32_t line)
else
{
// Some lines have been populated, start where we last left off
assert("Not implemented yet" == NULL);
assert("Not implemented yet" && false);
}

}
else
{
// Calculate all line offsets up to "line"
assert("Not implemented yet" == NULL);
assert("Not implemented yet" && false);
}
return false;
}
Expand Down

0 comments on commit 03439a8

Please sign in to comment.