Skip to content

Commit

Permalink
[libc++] Add a libc++ CI pipeline specific to Clang changes
Browse files Browse the repository at this point in the history
This will ensure that Clang changes get tested against libc++.

Differential Revision: https://reviews.llvm.org/D137759
  • Loading branch information
ldionne committed Nov 12, 2022
1 parent 4f2f7e8 commit 0389438
Show file tree
Hide file tree
Showing 3 changed files with 114 additions and 5 deletions.
103 changes: 103 additions & 0 deletions libcxx/utils/ci/buildkite-pipeline-clang.yml
@@ -0,0 +1,103 @@
#===----------------------------------------------------------------------===##
#
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#
#===----------------------------------------------------------------------===##

#
# This file describes the various pre-commit CI bots used to test Clang against
# libc++ under various configurations. Unlike the usual libc++ CI pipeline,
# which aims to test libc++ itself, this pipeline aims to test Clang by
# compiling libc++ and running its test suite against the just-built Clang,
# in various configurations.
#
env:
LLVM_HEAD_VERSION: "16"
steps:
- label: "Building clang"
commands:
- "mkdir install"
- "cmake -S llvm -B build -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=install -DLLVM_ENABLE_PROJECTS=\"clang;compiler-rt\""
- "ninja -C build install-clang install-clang-resource-headers"
- "buildkite-agent artifact upload 'install/**/*'"
env:
CC: "clang-${LLVM_HEAD_VERSION}"
CXX: "clang++-${LLVM_HEAD_VERSION}"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- wait

- label: "C++03"
commands:
- "buildkite-agent artifact download 'install/**' ."
- "export CC=$(pwd)/install/bin/clang"
- "export CXX=$(pwd)/install/bin/clang++"
- "chmod +x install/bin/clang install/bin/clang++"
- "libcxx/utils/ci/run-buildbot generic-cxx03"
artifact_paths:
- "**/test-results.xml"
- "**/crash_diagnostics/*"
env:
LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "C++2b"
commands:
- "buildkite-agent artifact download 'install/**' ."
- "export CC=$(pwd)/install/bin/clang"
- "export CXX=$(pwd)/install/bin/clang++"
- "chmod +x install/bin/clang install/bin/clang++"
- "libcxx/utils/ci/run-buildbot generic-cxx2b"
artifact_paths:
- "**/test-results.xml"
- "**/crash_diagnostics/*"
env:
LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120

- label: "Modules"
commands:
- "buildkite-agent artifact download 'install/**' ."
- "export CC=$(pwd)/install/bin/clang"
- "export CXX=$(pwd)/install/bin/clang++"
- "chmod +x install/bin/clang install/bin/clang++"
- "libcxx/utils/ci/run-buildbot generic-modules"
artifact_paths:
- "**/test-results.xml"
- "**/crash_diagnostics/*"
env:
LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
agents:
queue: "libcxx-builders"
os: "linux"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2
timeout_in_minutes: 120
6 changes: 2 additions & 4 deletions libcxx/utils/ci/buildkite-pipeline-premerge.sh
Expand Up @@ -15,10 +15,8 @@
# Invoked by CI on pre-merge check for a commit.
#

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"

if ! git diff --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/"; then
# libcxx/, libcxxabi/, libunwind/, runtimes/ or cmake/ are not affected
if ! git diff --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/|^clang/"; then
# libcxx/, libcxxabi/, libunwind/, runtimes/, cmake/ or clang/ are not affected
exit 0
fi

Expand Down
10 changes: 9 additions & 1 deletion libcxx/utils/ci/generate-buildkite-pipeline
Expand Up @@ -7,4 +7,12 @@
#
#===----------------------------------------------------------------------===##

cat libcxx/utils/ci/buildkite-pipeline.yml
#
# This script generates the appropriate libc++ CI pipeline based on which project(s) were changed.
#

if git diff --name-only HEAD~1 | grep -q -E "^libcxx/|^libcxxabi/|^libunwind/|^runtimes/|^cmake/"; then
cat libcxx/utils/ci/buildkite-pipeline.yml
elif git diff --name-only HEAD~1 | grep -q -E "^clang/"; then
cat libcxx/utils/ci/buildkite-pipeline-clang.yml
fi

0 comments on commit 0389438

Please sign in to comment.