Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
StringRefZ does not improve performance. Non-local symbols always have eagerly computed nameSize. Most local symbols's lengths will be updated in either: * shouldKeepInSymtab * SymbolTableBaseSection::addSymbol Its benefit is offsetted by strlen in every call site (sums up to 5KiB code in a release x86-64 build), so using StringRefZ may be slower. In a -s link (uncommon) there is minor speedup, like ~0.3% for clang and chrome. Reviewed By: alexander-shaposhnikov Differential Revision: https://reviews.llvm.org/D117644
- Loading branch information
Showing
2 changed files
with
12 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters