-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The file name is WS2_32.Lib in all the Windows SDK versions I looked at. You can get away with the incorrect casing on a case-insensitive file system but it can matter for cross-compilation.
- Loading branch information
Showing
2 changed files
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
042a2e8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this fix probably fixed cross compilation with WinSDK, it still is broken with mingw, which consistently uses lowercase only. (Also note that lowercase is used consistently everywhere in the codebase as is; e.g. advapi32.lib is actually spelled AdvAPI32.Lib in the WinSDK.) I pushed a fix with a longer commit message about the situation, in 554e4df.
042a2e8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!