Skip to content

Commit

Permalink
Revert "[test] Remove occurences of br undef in CodeGen/AMDGPU tests"
Browse files Browse the repository at this point in the history
This reverts commit 18c594c.
Build bots broke
  • Loading branch information
nunoplopes committed Apr 4, 2023
1 parent d10e47d commit 047efda
Show file tree
Hide file tree
Showing 18 changed files with 65 additions and 65 deletions.
12 changes: 6 additions & 6 deletions llvm/test/CodeGen/AMDGPU/coalescer_distribute.ll
Expand Up @@ -2,13 +2,13 @@
; This testcase produces a situation with unused value numbers in subregister
; liveranges that get distributed by ConnectedVNInfoEqClasses.

define amdgpu_kernel void @hoge(i1 %c0, i1 %c1, i1 %c2, i1 %c3, i1 %c4) {
define amdgpu_kernel void @hoge() {
bb:
%tmp = tail call i32 @llvm.amdgcn.workitem.id.x()
br i1 %c0, label %bb2, label %bb23
br i1 undef, label %bb2, label %bb23

bb2:
br i1 %c1, label %bb6, label %bb8
br i1 undef, label %bb6, label %bb8

bb6:
%tmp7 = or i64 undef, undef
Expand All @@ -20,7 +20,7 @@ bb8:
br i1 %tmp10, label %bb11, label %bb23

bb11:
br i1 %c2, label %bb20, label %bb17
br i1 undef, label %bb20, label %bb17

bb17:
br label %bb20
Expand All @@ -36,10 +36,10 @@ bb23:

bb25:
%tmp26 = phi i32 [ %tmp24, %bb23 ], [ undef, %bb25 ]
br i1 %c3, label %bb25, label %bb30
br i1 undef, label %bb25, label %bb30

bb30:
br i1 %c4, label %bb32, label %bb34
br i1 undef, label %bb32, label %bb34

bb32:
%tmp33 = zext i32 %tmp26 to i64
Expand Down
28 changes: 14 additions & 14 deletions llvm/test/CodeGen/AMDGPU/extract-subvector.ll
Expand Up @@ -20,8 +20,8 @@
; GCN: v_bfe_i32
; GCN: v_bfe_i32

define <2 x i16> @extract_2xi16(ptr addrspace(1) %p0, ptr addrspace(1) %p1, i1 %c0) {
br i1 %c0, label %T, label %F
define <2 x i16> @extract_2xi16(ptr addrspace(1) %p0, ptr addrspace(1) %p1) {
br i1 undef, label %T, label %F

T:
%t = load volatile <8 x i16>, ptr addrspace(1) %p0
Expand All @@ -41,8 +41,8 @@ exit:

; GCN-LABEL: extract_2xi64
; GCN-COUNT-2: v_cndmask_b32
define <2 x i64> @extract_2xi64(ptr addrspace(1) %p0, ptr addrspace(1) %p1, i1 %c0) {
br i1 %c0, label %T, label %F
define <2 x i64> @extract_2xi64(ptr addrspace(1) %p0, ptr addrspace(1) %p1) {
br i1 undef, label %T, label %F

T:
%t = load volatile <8 x i64>, ptr addrspace(1) %p0
Expand All @@ -62,8 +62,8 @@ exit:

; GCN-LABEL: extract_4xi64
; GCN-COUNT-4: v_cndmask_b32
define <4 x i64> @extract_4xi64(ptr addrspace(1) %p0, ptr addrspace(1) %p1, i1 %c0) {
br i1 %c0, label %T, label %F
define <4 x i64> @extract_4xi64(ptr addrspace(1) %p0, ptr addrspace(1) %p1) {
br i1 undef, label %T, label %F

T:
%t = load volatile <8 x i64>, ptr addrspace(1) %p0
Expand All @@ -83,8 +83,8 @@ exit:

; GCN-LABEL: extract_8xi64
; GCN-COUNT-8: v_cndmask_b32
define <8 x i64> @extract_8xi64(ptr addrspace(1) %p0, ptr addrspace(1) %p1, i1 %c0) {
br i1 %c0, label %T, label %F
define <8 x i64> @extract_8xi64(ptr addrspace(1) %p0, ptr addrspace(1) %p1) {
br i1 undef, label %T, label %F

T:
%t = load volatile <16 x i64>, ptr addrspace(1) %p0
Expand All @@ -104,8 +104,8 @@ exit:

; GCN-LABEL: extract_2xf64
; GCN-COUNT-2: v_cndmask_b32
define <2 x double> @extract_2xf64(ptr addrspace(1) %p0, ptr addrspace(1) %p1, i1 %c0) {
br i1 %c0, label %T, label %F
define <2 x double> @extract_2xf64(ptr addrspace(1) %p0, ptr addrspace(1) %p1) {
br i1 undef, label %T, label %F

T:
%t = load volatile <8 x double>, ptr addrspace(1) %p0
Expand All @@ -125,8 +125,8 @@ exit:

; GCN-LABEL: extract_4xf64
; GCN-COUNT-4: v_cndmask_b32
define <4 x double> @extract_4xf64(ptr addrspace(1) %p0, ptr addrspace(1) %p1, i1 %c0) {
br i1 %c0, label %T, label %F
define <4 x double> @extract_4xf64(ptr addrspace(1) %p0, ptr addrspace(1) %p1) {
br i1 undef, label %T, label %F

T:
%t = load volatile <8 x double>, ptr addrspace(1) %p0
Expand All @@ -146,8 +146,8 @@ exit:

; GCN-LABEL: extract_8xf64
; GCN-COUNT-8: v_cndmask_b32
define <8 x double> @extract_8xf64(ptr addrspace(1) %p0, ptr addrspace(1) %p1, i1 %c0) {
br i1 %c0, label %T, label %F
define <8 x double> @extract_8xf64(ptr addrspace(1) %p0, ptr addrspace(1) %p1) {
br i1 undef, label %T, label %F

T:
%t = load volatile <16 x double>, ptr addrspace(1) %p0
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/i1-copy-phi.ll
Expand Up @@ -42,9 +42,9 @@ attributes #0 = { nounwind readnone }
; SI-LABEL: {{^}}vcopy_i1_undef
; SI: v_cndmask_b32_e64
; SI: v_cndmask_b32_e64
define <2 x float> @vcopy_i1_undef(ptr addrspace(1) %p, i1 %c0) {
define <2 x float> @vcopy_i1_undef(ptr addrspace(1) %p) {
entry:
br i1 %c0, label %exit, label %false
br i1 undef, label %exit, label %false

false:
%x = load <2 x float>, ptr addrspace(1) %p
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/implicit-def-muse.ll
Expand Up @@ -7,9 +7,9 @@
; CHECK-NOT: COPY [[IMPDEF0]]
; CHECK-NOT: COPY [[IMPDEF1]]
; CHECK: .false:
define <2 x float> @vcopy_i1_undef(ptr addrspace(1) %p, i1 %c0) {
define <2 x float> @vcopy_i1_undef(ptr addrspace(1) %p) {
entry:
br i1 %c0, label %exit, label %false
br i1 undef, label %exit, label %false

false:
%x = load <2 x float>, ptr addrspace(1) %p
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/inline-asm.ll
Expand Up @@ -299,9 +299,9 @@ entry:
; Check aggregate types are handled properly.
; CHECK-LABEL: mad_u64
; CHECK: v_mad_u64_u32
define void @mad_u64(i32 %x, i1 %c0) {
define void @mad_u64(i32 %x) {
entry:
br i1 %c0, label %exit, label %false
br i1 undef, label %exit, label %false

false:
%s0 = tail call { i64, i64 } asm sideeffect "v_mad_u64_u32 $0, $1, $2, $3, $4", "=v,=s,v,v,v"(i32 -766435501, i32 %x, i64 0)
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/large-constant-initializer.ll
Expand Up @@ -4,10 +4,10 @@

@gv = external unnamed_addr addrspace(4) constant [239 x i32], align 4

define amdgpu_kernel void @opencv_cvtfloat_crash(ptr addrspace(1) %out, i32 %x, i1 %c0) nounwind {
define amdgpu_kernel void @opencv_cvtfloat_crash(ptr addrspace(1) %out, i32 %x) nounwind {
%val = load i32, ptr addrspace(4) getelementptr ([239 x i32], ptr addrspace(4) @gv, i64 0, i64 239), align 4
%mul12 = mul nsw i32 %val, 7
br i1 %c0, label %exit, label %bb
br i1 undef, label %exit, label %bb

bb:
%cmp = icmp slt i32 %x, 0
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/mdt-preserving-crash.ll
Expand Up @@ -4,7 +4,7 @@ target triple = "amdgcn-amd-amdhsa"

@_RSENC_gDcd_______________________________ = external protected addrspace(1) externally_initialized global [4096 x i8], align 16

define protected amdgpu_kernel void @_RSENC_PRInit__________________________________(i1 %c0) local_unnamed_addr #0 {
define protected amdgpu_kernel void @_RSENC_PRInit__________________________________() local_unnamed_addr #0 {
entry:
%runtimeVersionCopy = alloca [128 x i8], align 16, addrspace(5)
%licenseVersionCopy = alloca [128 x i8], align 16, addrspace(5)
Expand All @@ -18,7 +18,7 @@ if.end: ; preds = %entry
br i1 %cmp13, label %cleanup.cont, label %if.end15

if.end15: ; preds = %if.end
br i1 %c0, label %cleanup.cont, label %lor.lhs.false17
br i1 undef, label %cleanup.cont, label %lor.lhs.false17

lor.lhs.false17: ; preds = %if.end15
br label %while.cond.i
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/mfma-cd-select.ll
Expand Up @@ -78,12 +78,12 @@ bb:

; GCN-LABEL: {{^}}test_mfma_f32_32x32x1f32_call_multi_bb:
; GCN: v_mfma_f32_32x32x1{{.*}} a[{{[0-9:]+}}], v{{[0-9]+}}, v{{[0-9:]+}}, a[{{[0-9:]+}}]
define amdgpu_kernel void @test_mfma_f32_32x32x1f32_call_multi_bb(ptr addrspace(1) %arg, i1 %c0) #0 {
define amdgpu_kernel void @test_mfma_f32_32x32x1f32_call_multi_bb(ptr addrspace(1) %arg) #0 {
bb1:
%in.1 = load <32 x float>, ptr addrspace(1) %arg
%mai.1 = tail call <32 x float> @llvm.amdgcn.mfma.f32.32x32x1f32(float 1.0, float 2.0, <32 x float> %in.1, i32 1, i32 2, i32 3)
store <32 x float> %mai.1, ptr addrspace(1) %arg
br i1 %c0, label %bb2, label %bb3
br i1 undef, label %bb2, label %bb3
br label %bb2

bb2:
Expand Down
16 changes: 8 additions & 8 deletions llvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-phi.ll
Expand Up @@ -13,10 +13,10 @@
; CHECK: endif:
; CHECK: %phi.ptr = phi ptr addrspace(3) [ %arrayidx0, %if ], [ %arrayidx1, %else ]
; CHECK: store i32 0, ptr addrspace(3) %phi.ptr, align 4
define amdgpu_kernel void @branch_ptr_var_same_alloca(i32 %a, i32 %b, i1 %c0) #0 {
define amdgpu_kernel void @branch_ptr_var_same_alloca(i32 %a, i32 %b) #0 {
entry:
%alloca = alloca [64 x i32], align 4, addrspace(5)
br i1 %c0, label %if, label %else
br i1 undef, label %if, label %else

if:
%arrayidx0 = getelementptr inbounds [64 x i32], ptr addrspace(5) %alloca, i32 0, i32 %a
Expand All @@ -34,10 +34,10 @@ endif:

; CHECK-LABEL: @branch_ptr_phi_alloca_null_0(
; CHECK: %phi.ptr = phi ptr addrspace(3) [ %arrayidx0, %if ], [ null, %entry ]
define amdgpu_kernel void @branch_ptr_phi_alloca_null_0(i32 %a, i32 %b, i1 %c0) #0 {
define amdgpu_kernel void @branch_ptr_phi_alloca_null_0(i32 %a, i32 %b) #0 {
entry:
%alloca = alloca [64 x i32], align 4, addrspace(5)
br i1 %c0, label %if, label %endif
br i1 undef, label %if, label %endif

if:
%arrayidx0 = getelementptr inbounds [64 x i32], ptr addrspace(5) %alloca, i32 0, i32 %a
Expand All @@ -51,10 +51,10 @@ endif:

; CHECK-LABEL: @branch_ptr_phi_alloca_null_1(
; CHECK: %phi.ptr = phi ptr addrspace(3) [ null, %entry ], [ %arrayidx0, %if ]
define amdgpu_kernel void @branch_ptr_phi_alloca_null_1(i32 %a, i32 %b, i1 %c0) #0 {
define amdgpu_kernel void @branch_ptr_phi_alloca_null_1(i32 %a, i32 %b) #0 {
entry:
%alloca = alloca [64 x i32], align 4, addrspace(5)
br i1 %c0, label %if, label %endif
br i1 undef, label %if, label %endif

if:
%arrayidx0 = getelementptr inbounds [64 x i32], ptr addrspace(5) %alloca, i32 0, i32 %a
Expand Down Expand Up @@ -97,10 +97,10 @@ exit:
; CHECK: endif:
; CHECK: %phi.ptr = phi ptr addrspace(5) [ %arrayidx0, %if ], [ %arrayidx1, %else ]
; CHECK: store i32 0, ptr addrspace(5) %phi.ptr, align 4
define amdgpu_kernel void @branch_ptr_alloca_unknown_obj(i32 %a, i32 %b, i1 %c0) #0 {
define amdgpu_kernel void @branch_ptr_alloca_unknown_obj(i32 %a, i32 %b) #0 {
entry:
%alloca = alloca [64 x i32], align 4, addrspace(5)
br i1 %c0, label %if, label %else
br i1 undef, label %if, label %else

if:
%arrayidx0 = getelementptr inbounds [64 x i32], ptr addrspace(5) %alloca, i32 0, i32 %a
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-select.ll
Expand Up @@ -77,13 +77,13 @@ define amdgpu_kernel void @lds_promoted_alloca_select_input_select(i32 %a, i32 %
ret void
}

define amdgpu_kernel void @lds_promoted_alloca_select_input_phi(i32 %a, i32 %b, i32 %c, i1 %c0) #0 {
define amdgpu_kernel void @lds_promoted_alloca_select_input_phi(i32 %a, i32 %b, i32 %c) #0 {
entry:
%alloca = alloca [16 x i32], align 4, addrspace(5)
%ptr0 = getelementptr inbounds [16 x i32], ptr addrspace(5) %alloca, i32 0, i32 %a
%ptr1 = getelementptr inbounds [16 x i32], ptr addrspace(5) %alloca, i32 0, i32 %b
store i32 0, ptr addrspace(5) %ptr0
br i1 %c0, label %bb1, label %bb2
br i1 undef, label %bb1, label %bb2

bb1:
%ptr2 = getelementptr inbounds [16 x i32], ptr addrspace(5) %alloca, i32 0, i32 %c
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/reg-coalescer-sched-crash.ll
Expand Up @@ -6,7 +6,7 @@

declare i32 @llvm.amdgcn.workitem.id.x() #0

define amdgpu_kernel void @reg_coalescer_breaks_dead(ptr addrspace(1) nocapture readonly %arg, i32 %arg1, i32 %arg2, i32 %arg3, i1 %c0) #1 {
define amdgpu_kernel void @reg_coalescer_breaks_dead(ptr addrspace(1) nocapture readonly %arg, i32 %arg1, i32 %arg2, i32 %arg3) #1 {
bb:
%id.x = call i32 @llvm.amdgcn.workitem.id.x()
%cmp0 = icmp eq i32 %id.x, 0
Expand All @@ -18,7 +18,7 @@ bb3: ; preds = %bb

bb4: ; preds = %bb6, %bb
%tmp5 = phi <2 x i32> [ zeroinitializer, %bb ], [ %tmp13, %bb6 ]
br i1 %c0, label %bb15, label %bb16
br i1 undef, label %bb15, label %bb16

bb6: ; preds = %bb6, %bb3
%tmp7 = phi <2 x i32> [ zeroinitializer, %bb3 ], [ %tmp13, %bb6 ]
Expand Down
8 changes: 4 additions & 4 deletions llvm/test/CodeGen/AMDGPU/rename-disconnected-bug.ll
Expand Up @@ -3,23 +3,23 @@
; definition on every path (there should at least be IMPLICIT_DEF instructions).
target triple = "amdgcn--"

define amdgpu_kernel void @func(i1 %c0, i1 %c1, i1 %c2) {
define amdgpu_kernel void @func() {
B0:
br i1 %c0, label %B1, label %B2
br i1 undef, label %B1, label %B2

B1:
br label %B2

B2:
%v0 = phi <4 x float> [ zeroinitializer, %B1 ], [ <float 0.0, float 0.0, float 0.0, float undef>, %B0 ]
br i1 %c1, label %B20.1, label %B20.2
br i1 undef, label %B20.1, label %B20.2

B20.1:
br label %B20.2

B20.2:
%v2 = phi <4 x float> [ zeroinitializer, %B20.1 ], [ %v0, %B2 ]
br i1 %c2, label %B30.1, label %B30.2
br i1 undef, label %B30.1, label %B30.2

B30.1:
%sub = fsub <4 x float> %v2, undef
Expand Down
4 changes: 2 additions & 2 deletions llvm/test/CodeGen/AMDGPU/si-annotate-cf-unreachable.ll
Expand Up @@ -11,7 +11,7 @@
; GCN: s_and_saveexec_b64
; GCN-NOT: s_endpgm
; GCN: .Lfunc_end0
define amdgpu_kernel void @annotate_unreachable(ptr addrspace(1) noalias nocapture readonly %arg, i1 %c0) #0 {
define amdgpu_kernel void @annotate_unreachable(ptr addrspace(1) noalias nocapture readonly %arg) #0 {
bb:
%tmp = tail call i32 @llvm.amdgcn.workitem.id.x()
br label %bb1
Expand All @@ -20,7 +20,7 @@ bb1: ; preds = %bb
%tmp2 = sext i32 %tmp to i64
%tmp3 = getelementptr inbounds <4 x float>, ptr addrspace(1) %arg, i64 %tmp2
%tmp4 = load <4 x float>, ptr addrspace(1) %tmp3, align 16
br i1 %c0, label %bb3, label %bb5 ; label order reversed
br i1 undef, label %bb3, label %bb5 ; label order reversed

bb3: ; preds = %bb1
%tmp6 = extractelement <4 x float> %tmp4, i32 2
Expand Down
14 changes: 7 additions & 7 deletions llvm/test/CodeGen/AMDGPU/simplifydemandedbits-recursion.ll
Expand Up @@ -19,7 +19,7 @@ declare i32 @llvm.amdgcn.workitem.id.x() #0
declare float @llvm.fmuladd.f32(float, float, float) #0

; CHECK: s_endpgm
define amdgpu_kernel void @foo(ptr addrspace(1) noalias nocapture readonly %arg, ptr addrspace(1) noalias nocapture readonly %arg1, ptr addrspace(1) noalias nocapture %arg2, float %arg3, i1 %c0, i1 %c1, i1 %c2, i1 %c3, i1 %c4, i1 %c5) local_unnamed_addr !reqd_work_group_size !0 {
define amdgpu_kernel void @foo(ptr addrspace(1) noalias nocapture readonly %arg, ptr addrspace(1) noalias nocapture readonly %arg1, ptr addrspace(1) noalias nocapture %arg2, float %arg3) local_unnamed_addr !reqd_work_group_size !0 {
bb:
%tmp = tail call i32 @llvm.amdgcn.workitem.id.y()
%tmp4 = tail call i32 @llvm.amdgcn.workitem.id.x()
Expand All @@ -31,7 +31,7 @@ bb:
br label %bb12

bb11: ; preds = %bb30
br i1 %c0, label %bb37, label %bb38
br i1 undef, label %bb37, label %bb38

bb12: ; preds = %bb30, %bb
br i1 false, label %.preheader, label %.loopexit145
Expand All @@ -43,7 +43,7 @@ bb13: ; preds = %.loopexit, %.loopex
%tmp14 = phi i32 [ %tmp5, %.loopexit145 ], [ %tmp20, %.loopexit ]
%tmp15 = add nsw i32 %tmp14, -3
%tmp16 = mul i32 %tmp14, 21
br i1 %c1, label %bb17, label %.loopexit
br i1 undef, label %bb17, label %.loopexit

bb17: ; preds = %bb13
%tmp18 = mul i32 %tmp15, 224
Expand All @@ -52,15 +52,15 @@ bb17: ; preds = %bb13

.loopexit: ; preds = %bb21, %bb13
%tmp20 = add nuw nsw i32 %tmp14, 16
br i1 %c2, label %bb13, label %bb26
br i1 undef, label %bb13, label %bb26

bb21: ; preds = %bb21, %bb17
%tmp22 = phi i32 [ %tmp4, %bb17 ], [ %tmp25, %bb21 ]
%tmp23 = add i32 %tmp22, %tmp16
%tmp24 = getelementptr inbounds float, ptr addrspace(3) @0, i32 %tmp23
store float undef, ptr addrspace(3) %tmp24, align 4
%tmp25 = add nuw i32 %tmp22, 8
br i1 %c3, label %bb21, label %.loopexit
br i1 undef, label %bb21, label %.loopexit

bb26: ; preds = %.loopexit
br label %bb31
Expand All @@ -72,15 +72,15 @@ bb26: ; preds = %.loopexit
br i1 %tmp29, label %.preheader, label %.loopexit145

bb30: ; preds = %bb31
br i1 %c4, label %bb11, label %bb12
br i1 undef, label %bb11, label %bb12

bb31: ; preds = %bb31, %bb26
%tmp32 = phi i32 [ %tmp9, %bb26 ], [ undef, %bb31 ]
%tmp33 = getelementptr inbounds [462 x float], ptr addrspace(3) @0, i32 0, i32 %tmp32
%tmp34 = load float, ptr addrspace(3) %tmp33, align 4
%tmp35 = tail call float @llvm.fmuladd.f32(float %tmp34, float undef, float undef)
%tmp36 = tail call float @llvm.fmuladd.f32(float undef, float undef, float %tmp35)
br i1 %c5, label %bb30, label %bb31
br i1 undef, label %bb30, label %bb31

bb37: ; preds = %bb11
br label %bb38
Expand Down

0 comments on commit 047efda

Please sign in to comment.