Skip to content

Commit

Permalink
[libc++] Properly handle --no-execute in the new format
Browse files Browse the repository at this point in the history
If --no-execute is passed, we shouldn't report XFAIL tests as passing,
or they will be considered to XPASS.
  • Loading branch information
ldionne committed Apr 27, 2020
1 parent 4687b45 commit 05ef484
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libcxx/utils/libcxx/test/newformat.py
Expand Up @@ -333,7 +333,7 @@ def _executeShTest(self, test, litConfig, steps, fileDependencies=None):
return script

if litConfig.noExecute:
return lit.Test.Result(lit.Test.PASS)
return lit.Test.Result(lit.Test.XFAIL if test.isExpectedToFail() else lit.Test.PASS)
else:
_, tmpBase = lit.TestRunner.getTempPaths(test)
useExternalSh = True
Expand Down

0 comments on commit 05ef484

Please sign in to comment.