Skip to content

Commit

Permalink
[MC] Default MCAsmInfo::UseIntegratedAssembler to true
Browse files Browse the repository at this point in the history
  • Loading branch information
MaskRay committed Apr 11, 2020
1 parent d2e5157 commit 0a55d3f
Show file tree
Hide file tree
Showing 13 changed files with 1 addition and 34 deletions.
2 changes: 1 addition & 1 deletion llvm/lib/MC/MCAsmInfo.cpp
Expand Up @@ -64,7 +64,7 @@ MCAsmInfo::MCAsmInfo() {
// - Generic_GCC toolchains enable the integrated assembler on a per
// architecture basis.
// - The target subclasses for AArch64, ARM, and X86 handle these cases
UseIntegratedAssembler = false;
UseIntegratedAssembler = true;
PreserveAsmComments = true;
}

Expand Down
2 changes: 0 additions & 2 deletions llvm/lib/MC/MCAsmInfoCOFF.cpp
Expand Up @@ -36,8 +36,6 @@ MCAsmInfoCOFF::MCAsmInfoCOFF() {
SupportsDebugInformation = true;
NeedsDwarfSectionOffsetDirective = true;

UseIntegratedAssembler = true;

// At least MSVC inline-asm does AShr.
UseLogicalShr = false;

Expand Down
2 changes: 0 additions & 2 deletions llvm/lib/MC/MCAsmInfoDarwin.cpp
Expand Up @@ -91,7 +91,5 @@ MCAsmInfoDarwin::MCAsmInfoDarwin() {
HasAltEntry = true;

DwarfUsesRelocationsAcrossSections = false;

UseIntegratedAssembler = true;
SetDirectiveSuppressesReloc = true;
}
2 changes: 0 additions & 2 deletions llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
Expand Up @@ -96,8 +96,6 @@ AArch64MCAsmInfoELF::AArch64MCAsmInfoELF(const Triple &T) {
// Exceptions handling
ExceptionsType = ExceptionHandling::DwarfCFI;

UseIntegratedAssembler = true;

HasIdentDirective = true;
}

Expand Down
5 changes: 0 additions & 5 deletions llvm/lib/Target/ARM/MCTargetDesc/ARMMCAsmInfo.cpp
Expand Up @@ -37,8 +37,6 @@ ARMMCAsmInfoDarwin::ARMMCAsmInfoDarwin(const Triple &TheTriple) {
ExceptionsType = (TheTriple.isOSDarwin() && !TheTriple.isWatchABI())
? ExceptionHandling::SjLj
: ExceptionHandling::DwarfCFI;

UseIntegratedAssembler = true;
}

void ARMELFMCAsmInfo::anchor() { }
Expand Down Expand Up @@ -73,8 +71,6 @@ ARMELFMCAsmInfo::ARMELFMCAsmInfo(const Triple &TheTriple) {

// foo(plt) instead of foo@plt
UseParensForSymbolVariant = true;

UseIntegratedAssembler = true;
}

void ARMELFMCAsmInfo::setUseIntegratedAssembler(bool Value) {
Expand Down Expand Up @@ -116,7 +112,6 @@ ARMCOFFMCAsmInfoGNU::ARMCOFFMCAsmInfoGNU() {
ExceptionsType = ExceptionHandling::DwarfCFI;
UseParensForSymbolVariant = true;

UseIntegratedAssembler = true;
DwarfRegNumForCFI = false;

// Conditional Thumb 4-byte instructions can have an implicit IT.
Expand Down
1 change: 0 additions & 1 deletion llvm/lib/Target/AVR/MCTargetDesc/AVRMCAsmInfo.cpp
Expand Up @@ -23,7 +23,6 @@ AVRMCAsmInfo::AVRMCAsmInfo(const Triple &TT, const MCTargetOptions &Options) {
PrivateGlobalPrefix = ".L";
PrivateLabelPrefix = ".L";
UsesELFSectionDirectiveForBSS = true;
UseIntegratedAssembler = true;
SupportsDebugInformation = true;
}

Expand Down
3 changes: 0 additions & 3 deletions llvm/lib/Target/Lanai/MCTargetDesc/LanaiMCAsmInfo.cpp
Expand Up @@ -28,9 +28,6 @@ LanaiMCAsmInfo::LanaiMCAsmInfo(const Triple & /*TheTriple*/,
// Lanai assembly requires ".section" before ".bss"
UsesELFSectionDirectiveForBSS = true;

// Use the integrated assembler instead of system one.
UseIntegratedAssembler = true;

// Use '!' as comment string to correspond with old toolchain.
CommentString = "!";

Expand Down
1 change: 0 additions & 1 deletion llvm/lib/Target/MSP430/MCTargetDesc/MSP430MCAsmInfo.cpp
Expand Up @@ -24,5 +24,4 @@ MSP430MCAsmInfo::MSP430MCAsmInfo(const Triple &TT,

AlignmentIsInBytes = false;
UsesELFSectionDirectiveForBSS = true;
UseIntegratedAssembler = true;
}
1 change: 0 additions & 1 deletion llvm/lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp
Expand Up @@ -50,5 +50,4 @@ MipsMCAsmInfo::MipsMCAsmInfo(const Triple &TheTriple,
ExceptionsType = ExceptionHandling::DwarfCFI;
DwarfRegNumForCFI = true;
HasMipsExpressions = true;
UseIntegratedAssembler = true;
}
2 changes: 0 additions & 2 deletions llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.cpp
Expand Up @@ -51,8 +51,6 @@ PPCELFMCAsmInfo::PPCELFMCAsmInfo(bool is64Bit, const Triple& T) {
Data64bitsDirective = is64Bit ? "\t.quad\t" : nullptr;
AssemblerDialect = 1; // New-Style mnemonics.
LCOMMDirectiveAlignmentType = LCOMM::ByteAlignment;

UseIntegratedAssembler = true;
}

void PPCXCOFFMCAsmInfo::anchor() {}
Expand Down
2 changes: 0 additions & 2 deletions llvm/lib/Target/Sparc/MCTargetDesc/SparcMCAsmInfo.cpp
Expand Up @@ -42,8 +42,6 @@ SparcELFMCAsmInfo::SparcELFMCAsmInfo(const Triple &TheTriple) {

SunStyleELFSectionSwitchSyntax = true;
UsesELFSectionDirectiveForBSS = true;

UseIntegratedAssembler = true;
}

const MCExpr*
Expand Down
2 changes: 0 additions & 2 deletions llvm/lib/Target/SystemZ/MCTargetDesc/SystemZMCAsmInfo.cpp
Expand Up @@ -23,6 +23,4 @@ SystemZMCAsmInfo::SystemZMCAsmInfo(const Triple &TT) {
UsesELFSectionDirectiveForBSS = true;
SupportsDebugInformation = true;
ExceptionsType = ExceptionHandling::DwarfCFI;

UseIntegratedAssembler = true;
}
10 changes: 0 additions & 10 deletions llvm/lib/Target/X86/MCTargetDesc/X86MCAsmInfo.cpp
Expand Up @@ -71,8 +71,6 @@ X86MCAsmInfoDarwin::X86MCAsmInfoDarwin(const Triple &T) {
// (actually, must, since otherwise the non-extern relocations we produce
// overwhelm ld64's tiny little mind and it fails).
DwarfFDESymbolsUseAbsDiff = true;

UseIntegratedAssembler = true;
}

X86_64MCAsmInfoDarwin::X86_64MCAsmInfoDarwin(const Triple &Triple)
Expand Down Expand Up @@ -102,10 +100,6 @@ X86ELFMCAsmInfo::X86ELFMCAsmInfo(const Triple &T) {

// Exceptions handling
ExceptionsType = ExceptionHandling::DwarfCFI;

// Always enable the integrated assembler by default.
// Clang also enabled it when the OS is Solaris but that is redundant here.
UseIntegratedAssembler = true;
}

const MCExpr *
Expand Down Expand Up @@ -141,8 +135,6 @@ X86MCAsmInfoMicrosoft::X86MCAsmInfoMicrosoft(const Triple &Triple) {
TextAlignFillValue = 0x90;

AllowAtInName = true;

UseIntegratedAssembler = true;
}

void X86MCAsmInfoMicrosoftMASM::anchor() { }
Expand Down Expand Up @@ -174,6 +166,4 @@ X86MCAsmInfoGNUCOFF::X86MCAsmInfoGNUCOFF(const Triple &Triple) {
TextAlignFillValue = 0x90;

AllowAtInName = true;

UseIntegratedAssembler = true;
}

0 comments on commit 0a55d3f

Please sign in to comment.