Skip to content

Commit

Permalink
[test][lld-macho] Improve LC_FUNCTION_STARTS test coverage
Browse files Browse the repository at this point in the history
Previously functions that aren't included in the symtab were also
excluded from the function starts. Symbols missing from function starts
degrades the debugger experience in the case you don't have debug info
for them.

Differential Revision: https://reviews.llvm.org/D114275
  • Loading branch information
keith committed Jan 30, 2022
1 parent 2cdbaca commit 0ab09a9
Showing 1 changed file with 27 additions and 0 deletions.
27 changes: 27 additions & 0 deletions lld/test/MachO/function-starts.s
Expand Up @@ -41,6 +41,21 @@
# RUN: llvm-objdump --macho --function-starts %t/basic >> %t/objdump
# RUN: FileCheck %s --check-prefix=BASIC < %t/objdump

# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/local.s -o %t/local.o
# RUN: %lld -lSystem %t/local.o -o %t/local
# RUN: llvm-objdump --syms %t/local > %t/objdump
# RUN: llvm-objdump --macho --function-starts %t/local >> %t/objdump
# RUN: FileCheck %s --check-prefix=LOCAL < %t/objdump

# LOCAL-LABEL: SYMBOL TABLE:
# LOCAL-NEXT: [[#%x,F1:]] l F __TEXT,__text +[Foo bar]
# LOCAL-NEXT: [[#%x,F2:]] l F __TEXT,__text _foo
# LOCAL: [[#%x,F3:]] g F __TEXT,__text _main
# LOCAL-LABEL: local:
# LOCAL: [[#F1]]
# LOCAL: [[#F2]]
# LOCAL: [[#F3]]

#--- basic.s
.section __TEXT,__text,regular,pure_instructions
.globl _f1
Expand All @@ -62,3 +77,15 @@ _f1:
retq
_main:
retq

#--- local.s
.section __TEXT,__text
"+[Foo bar]":
retq

_foo:
retq

.globl _main
_main:
retq

0 comments on commit 0ab09a9

Please sign in to comment.