Skip to content

Commit

Permalink
[LLVM][NFC] Removing unused functions
Browse files Browse the repository at this point in the history
Summary: Removes a not so useful function from DataLayout and cleans up Support/MathExtras.h

Reviewers: courbet

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66691

llvm-svn: 369824
  • Loading branch information
gchatelet committed Aug 23, 2019
1 parent 05bc146 commit 0b6563e
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 24 deletions.
4 changes: 0 additions & 4 deletions llvm/include/llvm/IR/DataLayout.h
Expand Up @@ -494,10 +494,6 @@ class DataLayout {
/// This is always at least as good as the ABI alignment.
unsigned getPrefTypeAlignment(Type *Ty) const;

/// Returns the preferred alignment for the specified type, returned as
/// log2 of the value (a shift amount).
unsigned getPreferredTypeAlignmentShift(Type *Ty) const;

/// Returns an integer type with size at least as big as that of a
/// pointer in the given address space.
IntegerType *getIntPtrType(LLVMContext &C, unsigned AddressSpace = 0) const;
Expand Down
13 changes: 0 additions & 13 deletions llvm/include/llvm/Support/MathExtras.h
Expand Up @@ -704,19 +704,6 @@ inline uint64_t divideCeil(uint64_t Numerator, uint64_t Denominator) {
return alignTo(Numerator, Denominator) / Denominator;
}

/// \c alignTo for contexts where a constant expression is required.
/// \sa alignTo
///
/// \todo FIXME: remove when \c constexpr becomes really \c constexpr
template <uint64_t Align>
struct AlignTo {
static_assert(Align != 0u, "Align must be non-zero");
template <uint64_t Value>
struct from_value {
static const uint64_t value = (Value + Align - 1) / Align * Align;
};
};

/// Returns the largest uint64_t less than or equal to \p Value and is
/// \p Skew mod \p Align. \p Align must be non-zero
inline uint64_t alignDown(uint64_t Value, uint64_t Align, uint64_t Skew = 0) {
Expand Down
6 changes: 0 additions & 6 deletions llvm/lib/IR/DataLayout.cpp
Expand Up @@ -763,12 +763,6 @@ unsigned DataLayout::getPrefTypeAlignment(Type *Ty) const {
return getAlignment(Ty, false);
}

unsigned DataLayout::getPreferredTypeAlignmentShift(Type *Ty) const {
unsigned Align = getPrefTypeAlignment(Ty);
assert(!(Align & (Align-1)) && "Alignment is not a power of two!");
return Log2_32(Align);
}

IntegerType *DataLayout::getIntPtrType(LLVMContext &C,
unsigned AddressSpace) const {
return IntegerType::get(C, getIndexSizeInBits(AddressSpace));
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Target/XCore/XCoreAsmPrinter.cpp
Expand Up @@ -115,7 +115,7 @@ void XCoreAsmPrinter::EmitGlobalVariable(const GlobalVariable *GV) {

MCSymbol *GVSym = getSymbol(GV);
const Constant *C = GV->getInitializer();
unsigned Align = (unsigned)DL.getPreferredTypeAlignmentShift(C->getType());
unsigned Align = Log2_32(DL.getPrefTypeAlignment(C->getType()));

// Mark the start of the global
getTargetStreamer().emitCCTopData(GVSym->getName());
Expand Down

0 comments on commit 0b6563e

Please sign in to comment.