Skip to content

Commit

Permalink
[llvm][Support][modulemap] Exclude WindowsSupport.h from the LLVM_Uti…
Browse files Browse the repository at this point in the history
…l module

rG01f9abbb50b1 moved WindowsSupport.h to include/llvm/Support/Windows/

This is a problem because the modulemap include all of the Support and
ADT directories, thus any use of any header in Support or ADT would
cause the compiler to try to build WindowsSupport.h, which only works
on Windows.

Fix this by explicitly excluding WindowsSupport.h from the LLVM_Util
module.
  • Loading branch information
Bigcheese committed Feb 28, 2020
1 parent c54597b commit 0b6abe4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions llvm/include/llvm/module.modulemap
Expand Up @@ -382,6 +382,9 @@ module LLVM_Utils {

umbrella "Support"
module * { export * }

// Exclude this; it should only be used on Windows.
exclude header "Support/Windows/WindowsSupport.h"

// Exclude these; they are fundamentally non-modular.
exclude header "Support/PluginLoader.h"
Expand Down

0 comments on commit 0b6abe4

Please sign in to comment.