Skip to content

Commit

Permalink
[scudo] Temporarily disable GetRssFromBuffer test
Browse files Browse the repository at this point in the history
This is a flaky test and may not test the thing it expected to verify.
E.g., it doesn't dirty the pages so the memory usage may not be reflected
on the RSS.

Reviewed By: cferris

Differential Revision: https://reviews.llvm.org/D145126
  • Loading branch information
ChiaHungDuan committed Mar 6, 2023
1 parent 436ea54 commit 0bd4499
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions compiler-rt/lib/scudo/standalone/tests/common_test.cpp
Expand Up @@ -69,9 +69,11 @@ TEST(ScudoCommonTest, Zeros) {
unmap(P, Size, 0, &Data);
}

#if SCUDO_LINUX && !defined(__powerpc__)
// This test fails intermediately on PPC, which is why this test is disabled
// for now on this platform.
#if 0
// This test is temorarily disabled because it may not work as expected. E.g.,
// it doesn't dirty the pages so the pages may not be commited and it may only
// work on the single thread environment. As a result, this test is flaky and is
// impacting many test scenarios.
TEST(ScudoCommonTest, GetRssFromBuffer) {
constexpr int64_t AllocSize = 10000000;
constexpr int64_t Error = 3000000;
Expand All @@ -88,6 +90,6 @@ TEST(ScudoCommonTest, GetRssFromBuffer) {
EXPECT_LE(std::abs(Rss - AllocSize - Prev), Error);
}
}
#endif // SCUDO_LINUX
#endif

} // namespace scudo

0 comments on commit 0bd4499

Please sign in to comment.