-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[clang] Disable missing definition warning on pure virtual functions (#…
…74510) Warning '-Wundefined-func-template' incorrectly indicates that no definition is available for a pure virtual function. However, a definition is not needed for a pure virtual function. Fixes #74016
- Loading branch information
Showing
3 changed files
with
75 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
clang/test/SemaTemplate/instantiate-pure-virtual-function.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
// RUN: %clang_cc1 -fsyntax-only -verify -Wundefined-func-template %s | ||
|
||
namespace GH74016 { | ||
template <typename T> class B { | ||
public: | ||
constexpr void foo(const T &) { bar(1); } | ||
virtual constexpr void bar(unsigned int) = 0; | ||
}; | ||
|
||
template <typename T> class D : public B<T> { | ||
public: | ||
constexpr void bar(unsigned int) override {} | ||
}; | ||
|
||
void test() { | ||
auto t = D<int>(); | ||
t.foo(0); | ||
} | ||
}; | ||
|
||
namespace call_pure_virtual_function_from_virtual { | ||
template <typename T> class B { | ||
public: | ||
const void foo(const T &) { B::bar(1); } // expected-warning {{instantiation of function 'call_pure_virtual_function_from_virtual::B<int>::bar' required here, but no definition is available}} | ||
// expected-note@-1 {{add an explicit instantiation declaration to suppress this warning if 'call_pure_virtual_function_from_virtual::B<int>::bar' is explicitly instantiated in another translation unit}} | ||
virtual const void bar(unsigned int) = 0; // expected-note {{forward declaration of template entity is here}} | ||
}; | ||
|
||
template <typename T> class D : public B<T> { | ||
public: | ||
const void bar(unsigned int) override {} | ||
}; | ||
|
||
void test() { | ||
auto t = D<int>(); | ||
t.foo(0); // expected-note {{in instantiation of member function 'call_pure_virtual_function_from_virtual::B<int>::foo' requested here}} | ||
} | ||
}; | ||
|
||
namespace non_pure_virtual_function { | ||
template <typename T> class B { | ||
public: | ||
constexpr void foo(const T &) { bar(1); } | ||
|
||
virtual constexpr void bar(unsigned int); // expected-warning {{inline function 'non_pure_virtual_function::B<int>::bar' is not defined}} | ||
// expected-note@-1 {{forward declaration of template entity is here}} | ||
// expected-note@-2 {{forward declaration of template entity is here}} | ||
// expected-note@-3 {{forward declaration of template entity is here}} | ||
}; | ||
|
||
template <typename T> class D : public B<T> { // expected-warning {{instantiation of function 'non_pure_virtual_function::B<int>::bar' required here, but no definition is available}} | ||
// expected-warning@-1 {{instantiation of function 'non_pure_virtual_function::B<int>::bar' required here, but no definition is available}} | ||
// expected-warning@-2 {{instantiation of function 'non_pure_virtual_function::B<int>::bar' required here, but no definition is available}} | ||
// expected-note@-3 {{add an explicit instantiation declaration to suppress this warning if 'non_pure_virtual_function::B<int>::bar' is explicitly instantiated in another translation unit}} | ||
// expected-note@-4 {{add an explicit instantiation declaration to suppress this warning if 'non_pure_virtual_function::B<int>::bar' is explicitly instantiated in another translation unit}} | ||
// expected-note@-5 {{add an explicit instantiation declaration to suppress this warning if 'non_pure_virtual_function::B<int>::bar' is explicitly instantiated in another translation unit}} | ||
// expected-note@-6 {{used here}} | ||
|
||
public: | ||
constexpr void bar(unsigned int) override { } | ||
}; | ||
|
||
void test() { | ||
auto t = D<int>(); | ||
t.foo(0); | ||
} | ||
}; |