Skip to content

Commit

Permalink
[build.py] Allow clang-cl to build files starting with '/U'
Browse files Browse the repository at this point in the history
Summary:
clang-cl tries to match cl's interface, and treats /U as "Removes a
predefined macro" as cl does. When you feed clang-cl a file that begins with
'/U' (e.g. /Users/xiaobai/foo.c), clang-cl will emit a warning and in some cases
an error, like so:

clang-9: warning: '/Users/xiaobai/foo.c' treated as the '/U' option [-Wslash-u-filename]
clang-9: note: Use '--' to treat subsequent arguments as filenames
clang-9: error: no input files

If you're using clang-cl, make sure '--' is passed before the source file.

Differential Revision: https://reviews.llvm.org/D58860

llvm-svn: 355341
  • Loading branch information
bulbazord committed Mar 4, 2019
1 parent 5be71fa commit 0ca4f84
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lldb/lit/helper/build.py
Expand Up @@ -568,6 +568,8 @@ def _get_compilation_command(self, source, obj):
args.append('/c')

args.append('/Fo' + obj)
if self.toolchain_type == 'clang-cl':
args.append('--')
args.append(source)

return ('compiling', [source], obj,
Expand Down

0 comments on commit 0ca4f84

Please sign in to comment.