Revert "[pgo] Avoid introducing relocations by using private alias"

This reverts commit 2b8917f. This breaks with lld and gold
llvm · Nov 16, 2022 · 0cc8752 · 0cc8752
1 parent 5c3ca10
commit 0cc8752
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 34 deletions.
diff --git a/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp b/llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
@@ -1014,17 +1014,9 @@ InstrProfiling::getOrCreateRegionCounters(InstrProfInstBase *Inc) {
   };
   auto *DataTy = StructType::get(Ctx, makeArrayRef(DataTypes));
 
-  Constant *FunctionAddr;
-  if (shouldRecordFunctionAddr(Fn)) {
-    // When possible use a private alias to avoid relocations
-    Constant *Addr = !Fn->isDeclarationForLinker()
-                         ? static_cast<Constant *>(GlobalAlias::create(
-                               GlobalValue::PrivateLinkage, Fn->getName(), Fn))
-                         : Fn;
-    FunctionAddr = ConstantExpr::getBitCast(Addr, Int8PtrTy);
-  } else {
-    FunctionAddr = ConstantPointerNull::get(Int8PtrTy);
-  }
+  Constant *FunctionAddr = shouldRecordFunctionAddr(Fn)
+                               ? ConstantExpr::getBitCast(Fn, Int8PtrTy)
+                               : ConstantPointerNull::get(Int8PtrTy);
 
   Constant *Int16ArrayVals[IPVK_Last + 1];
   for (uint32_t Kind = IPVK_First; Kind <= IPVK_Last; ++Kind)

diff --git a/llvm/test/Transforms/PGOProfile/prof_avoid_relocs.ll b/llvm/test/Transforms/PGOProfile/prof_avoid_relocs.ll