Skip to content

Commit

Permalink
[clang] Handle lround/llround builtins
Browse files Browse the repository at this point in the history 
As for other floating-point rounding builtins that can be optimized
when build with -fno-math-errno, this patch adds support for lround
and llround.  It currently only optimize for AArch64 backend.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D61392

llvm-svn: 360896
  • Loading branch information
@zatrazz
zatrazz committed May 16, 2019
1 parent af8cda1 commit 0d9dcd7
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 12 deletions.
21 changes: 21 additions & 0 deletions clang/lib/CodeGen/CGBuiltin.cpp
View file
Expand Up @@ -1721,6 +1721,27 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
case Builtin::BI__builtin_truncl:
return RValue::get(emitUnaryBuiltin(*this, E, Intrinsic::trunc));

case Builtin::BIlround:
case Builtin::BIlroundf:
case Builtin::BIlroundl:
case Builtin::BI__builtin_lround:
case Builtin::BI__builtin_lroundf:
case Builtin::BI__builtin_lroundl: {
llvm::Type *ResultType = ConvertType(E->getType());
int Width = ResultType->getPrimitiveSizeInBits();
return RValue::get(emitUnaryBuiltin(*this, E,
Width == 32 ? Intrinsic::lround_i32
: Intrinsic::lround_i64));
}

case Builtin::BIllround:
case Builtin::BIllroundf:
case Builtin::BIllroundl:
case Builtin::BI__builtin_llround:
case Builtin::BI__builtin_llroundf:
case Builtin::BI__builtin_llroundl:
return RValue::get(emitUnaryBuiltin(*this, E, Intrinsic::llround));

default:
break;
}
Expand Down
10 changes: 10 additions & 0 deletions clang/test/CodeGen/builtins.c
View file
Expand Up @@ -256,6 +256,8 @@ void test_float_builtin_ops(float F, double D, long double LD) {
volatile float resf;
volatile double resd;
volatile long double resld;
volatile long int resli;
volatile long long int reslli;

resf = __builtin_fmodf(F,F);
// CHECK: frem float
Expand Down Expand Up @@ -380,6 +382,14 @@ void test_float_builtin_ops(float F, double D, long double LD) {
resld = __builtin_roundl(LD);
// CHECK: call x86_fp80 @llvm.round.f80

resli = __builtin_lroundf (F);
// CHECK: call i64 @llvm.lround.i64.f32

resli = __builtin_lround (D);
// CHECK: call i64 @llvm.lround.i64.f64

resli = __builtin_lroundl (LD);
// CHECK: call i64 @llvm.lround.i64.f80
}

// __builtin_longjmp isn't supported on all platforms, so only test it on X86.
Expand Down
12 changes: 6 additions & 6 deletions clang/test/CodeGen/math-builtins.c
View file
Expand Up @@ -362,9 +362,9 @@ void foo(double *d, float f, float *fp, long double *l, int *i, const char *c) {

__builtin_llround(f); __builtin_llroundf(f); __builtin_llroundl(f);

// NO__ERRNO: declare i64 @llround(double) [[READNONE]]
// NO__ERRNO: declare i64 @llroundf(float) [[READNONE]]
// NO__ERRNO: declare i64 @llroundl(x86_fp80) [[READNONE]]
// NO__ERRNO: declare i64 @llvm.llround.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.llround.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.llround.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @llround(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llroundf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llroundl(x86_fp80) [[NOT_READNONE]]
Expand Down Expand Up @@ -425,9 +425,9 @@ void foo(double *d, float f, float *fp, long double *l, int *i, const char *c) {

__builtin_lround(f); __builtin_lroundf(f); __builtin_lroundl(f);

// NO__ERRNO: declare i64 @lround(double) [[READNONE]]
// NO__ERRNO: declare i64 @lroundf(float) [[READNONE]]
// NO__ERRNO: declare i64 @lroundl(x86_fp80) [[READNONE]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @lround(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lroundf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lroundl(x86_fp80) [[NOT_READNONE]]
Expand Down
12 changes: 6 additions & 6 deletions clang/test/CodeGen/math-libcalls.c
View file
Expand Up @@ -317,9 +317,9 @@ void foo(double *d, float f, float *fp, long double *l, int *i, const char *c) {

llround(f); llroundf(f); llroundl(f);

// NO__ERRNO: declare i64 @llround(double) [[READNONE]]
// NO__ERRNO: declare i64 @llroundf(float) [[READNONE]]
// NO__ERRNO: declare i64 @llroundl(x86_fp80) [[READNONE]]
// NO__ERRNO: declare i64 @llvm.llround.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.llround.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.llround.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @llround(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llroundf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @llroundl(x86_fp80) [[NOT_READNONE]]
Expand Down Expand Up @@ -380,9 +380,9 @@ void foo(double *d, float f, float *fp, long double *l, int *i, const char *c) {

lround(f); lroundf(f); lroundl(f);

// NO__ERRNO: declare i64 @lround(double) [[READNONE]]
// NO__ERRNO: declare i64 @lroundf(float) [[READNONE]]
// NO__ERRNO: declare i64 @lroundl(x86_fp80) [[READNONE]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f64(double) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f32(float) [[READNONE_INTRINSIC]]
// NO__ERRNO: declare i64 @llvm.lround.i64.f80(x86_fp80) [[READNONE_INTRINSIC]]
// HAS_ERRNO: declare i64 @lround(double) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lroundf(float) [[NOT_READNONE]]
// HAS_ERRNO: declare i64 @lroundl(x86_fp80) [[NOT_READNONE]]
Expand Down

0 comments on commit 0d9dcd7

Please sign in to comment.