Skip to content

Commit

Permalink
[bazel] Be consistent and say we don't support libfpm everywhere
Browse files Browse the repository at this point in the history
We're inconsistent about saying whether or not we support libfpm in the bazel build.

This should perhaps be configurable via a --config.

This allows the buildbots to see when llvm-exegesis-related breakages occur.

Differential Revision: https://reviews.llvm.org/D134510
  • Loading branch information
aeubanks committed Sep 23, 2022
1 parent 47c998c commit 0de7c15
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 17 deletions.
13 changes: 2 additions & 11 deletions utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
Expand Up @@ -2605,13 +2605,9 @@ cc_library(
for t in llvm_target_exegesis
]),
hdrs = glob(["tools/llvm-exegesis/lib/*.h"]),
copts = llvm_copts + ["-DHAVE_LIBPFM=1"],
copts = llvm_copts,
features = ["-header_modules"],
strip_include_prefix = "tools/llvm-exegesis/lib",
tags = [
"manual", # External dependency (libpfm4)
"nobuildkite", # TODO(chandlerc): Add support for fetching and building libpfm4 and enable this.
],
deps = [
":AllTargetsAsmParsers",
":AllTargetsCodeGens",
Expand Down Expand Up @@ -3082,13 +3078,8 @@ cc_binary(
srcs = [
"tools/llvm-exegesis/llvm-exegesis.cpp",
],
copts = llvm_copts + ["-DHAVE_LIBPFM=0"],
linkopts = ["-lpfm"],
copts = llvm_copts,
stamp = 0,
tags = [
"manual", # External dependency (libpfm4 through Exegesis)
"nobuildkite", # TODO(chandlerc): Enable when the library builds.
],
deps = [
":AllTargetsAsmParsers",
":AllTargetsCodeGens",
Expand Down
6 changes: 0 additions & 6 deletions utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel
Expand Up @@ -698,12 +698,6 @@ cc_test(
) + [
"tools/llvm-exegesis/Common/AssemblerUtils.h",
],
copts = ["-DHAVE_LIBPFM=1"],
linkopts = ["-lpfm"],
tags = [
"manual", # External dependency (libpfm4)
"nobuildkite", # TODO(chandlerc): Add support for fetching and building libpfm4 and enable this.
],
deps = [
"//llvm:AllTargetsCodeGens",
"//llvm:AllTargetsDisassemblers",
Expand Down

0 comments on commit 0de7c15

Please sign in to comment.