Skip to content

Commit

Permalink
[CodeGenPrepare] Don't split the store if it is volatile
Browse files Browse the repository at this point in the history
We shouldn't split the store when it is volatile.

Differential Revision: https://reviews.llvm.org/D61169

llvm-svn: 360228
  • Loading branch information
QingShan Zhang committed May 8, 2019
1 parent 17dbb19 commit 0e71a6e
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
4 changes: 4 additions & 0 deletions llvm/lib/CodeGen/CodeGenPrepare.cpp
Expand Up @@ -6657,6 +6657,10 @@ static bool splitMergedValStore(StoreInst &SI, const DataLayout &DL,
DL.getTypeSizeInBits(SplitStoreType))
return false;

// Don't split the store if it is volatile.
if (SI.isVolatile())
return false;

// Match the following patterns:
// (store (or (zext LValue to i64),
// (shl (zext HValue to i64), 32)), HalfValBitSize)
Expand Down
17 changes: 17 additions & 0 deletions llvm/test/CodeGen/PowerPC/splitstore-check-volatile.ll
@@ -0,0 +1,17 @@
; Test that CodeGenPrepare respect the volatile flag when splitting a store.
;
; RUN: opt -S -codegenprepare -force-split-store < %s | FileCheck %s

define void @fun(i16* %Src, i16* %Dst) {
; CHECK: store volatile i16 %8, i16* %Dst
%1 = load i16, i16* %Src
%2 = trunc i16 %1 to i8
%3 = lshr i16 %1, 8
%4 = trunc i16 %3 to i8
%5 = zext i8 %2 to i16
%6 = zext i8 %4 to i16
%7 = shl nuw i16 %6, 8
%8 = or i16 %7, %5
store volatile i16 %8, i16* %Dst
ret void
}

0 comments on commit 0e71a6e

Please sign in to comment.