Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DAG: Prevent store value forwarding to distinct addrspace load
DAGCombiner replaces (load const_addr1) directly chained with (store (val, const_addr2)) with val if address space stripped const_addr1 == const_addr2. The patch fixes the issue by checking address spaces as well. However, it might makes sense to not to chain together side effects that belong to different address spaces in the first place and make SelectionDAG::root address space aware.
- Loading branch information
1 parent
e50976e
commit 0ec51a4
Showing
2 changed files
with
22 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py | ||
; RUN: llc -mtriple=nvptx64 < %s | FileCheck %s | ||
|
||
define i64 @test() nounwind readnone { | ||
; CHECK-LABEL: test( | ||
; CHECK: { | ||
; CHECK-NEXT: .reg .b64 %rd<4>; | ||
; CHECK-EMPTY: | ||
; CHECK-NEXT: // %bb.0: | ||
; CHECK-NEXT: mov.u64 %rd1, 1; | ||
; CHECK-NEXT: mov.u64 %rd2, 42; | ||
; CHECK-NEXT: st.u64 [%rd1], %rd2; | ||
; CHECK-NEXT: ld.global.u64 %rd3, [%rd1]; | ||
; CHECK-NEXT: st.param.b64 [func_retval0+0], %rd3; | ||
; CHECK-NEXT: ret; | ||
%addr0 = inttoptr i64 1 to ptr | ||
%addr1 = inttoptr i64 1 to ptr addrspace(1) | ||
store i64 42, ptr %addr0 | ||
%res = load i64, ptr addrspace(1) %addr1 | ||
ret i64 %res | ||
} |