Skip to content

Commit

Permalink
[llvm] Deprecate {Bits,Float,Double}To{Bits,Float,Double} (NFC)
Browse files Browse the repository at this point in the history
Differential Revision: https://reviews.llvm.org/D143990
  • Loading branch information
kazutakahirata committed Feb 14, 2023
1 parent d180443 commit 0f52c1f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
4 changes: 4 additions & 0 deletions llvm/include/llvm/Support/MathExtras.h
Original file line number Diff line number Diff line change
Expand Up @@ -403,12 +403,14 @@ inline unsigned Log2_64_Ceil(uint64_t Value) {
}

/// This function takes a 64-bit integer and returns the bit equivalent double.
LLVM_DEPRECATED("use llvm::bit_cast instead", "llvm::bit_cast<double>")
inline double BitsToDouble(uint64_t Bits) {
static_assert(sizeof(uint64_t) == sizeof(double), "Unexpected type sizes");
return llvm::bit_cast<double>(Bits);
}

/// This function takes a 32-bit integer and returns the bit equivalent float.
LLVM_DEPRECATED("use llvm::bit_cast instead", "llvm::bit_cast<float>")
inline float BitsToFloat(uint32_t Bits) {
static_assert(sizeof(uint32_t) == sizeof(float), "Unexpected type sizes");
return llvm::bit_cast<float>(Bits);
Expand All @@ -417,6 +419,7 @@ inline float BitsToFloat(uint32_t Bits) {
/// This function takes a double and returns the bit equivalent 64-bit integer.
/// Note that copying doubles around changes the bits of NaNs on some hosts,
/// notably x86, so this routine cannot be used if these bits are needed.
LLVM_DEPRECATED("use llvm::bit_cast instead", "llvm::bit_cast<uint64_t>")
inline uint64_t DoubleToBits(double Double) {
static_assert(sizeof(uint64_t) == sizeof(double), "Unexpected type sizes");
return llvm::bit_cast<uint64_t>(Double);
Expand All @@ -425,6 +428,7 @@ inline uint64_t DoubleToBits(double Double) {
/// This function takes a float and returns the bit equivalent 32-bit integer.
/// Note that copying floats around changes the bits of NaNs on some hosts,
/// notably x86, so this routine cannot be used if these bits are needed.
LLVM_DEPRECATED("use llvm::bit_cast instead", "llvm::bit_cast<uint32_t>")
inline uint32_t FloatToBits(float Float) {
static_assert(sizeof(uint32_t) == sizeof(float), "Unexpected type sizes");
return llvm::bit_cast<uint32_t>(Float);
Expand Down
10 changes: 0 additions & 10 deletions llvm/unittests/Support/MathExtrasTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,6 @@ TEST(MathExtras, CTLog2) {
EXPECT_EQ(CTLog2<1ULL << 15>(), 15U);
}

TEST(MathExtras, FloatBits) {
static const float kValue = 5632.34f;
EXPECT_FLOAT_EQ(kValue, BitsToFloat(FloatToBits(kValue)));
}

TEST(MathExtras, DoubleBits) {
static const double kValue = 87987234.983498;
EXPECT_DOUBLE_EQ(kValue, BitsToDouble(DoubleToBits(kValue)));
}

TEST(MathExtras, MinAlign) {
EXPECT_EQ(1u, MinAlign(2, 3));
EXPECT_EQ(2u, MinAlign(2, 4));
Expand Down

0 comments on commit 0f52c1f

Please sign in to comment.