Skip to content

Commit

Permalink
[sanitizer_common][test] Disable CombinedAllocator32Compact etc. on S…
Browse files Browse the repository at this point in the history
…olaris/sparcv9

As reported in PR 48202, two allocator tests `FAIL` on Solaris/sparcv9,
presumably because Solaris uses the full 64-bit address space and the
allocator cannot deal with that:

  SanitizerCommon-Unit :: ./Sanitizer-sparcv9-Test/SanitizerCommon.CombinedAllocator32Compact
  SanitizerCommon-Unit :: ./Sanitizer-sparcv9-Test/SanitizerCommon.SizeClassAllocator32Iteration

This patch disables the tests.

Tested on `sparcv9-sun-solaris2.11`.

Differential Revision: https://reviews.llvm.org/D91622
  • Loading branch information
rorth committed Nov 20, 2020
1 parent ce6524d commit 0f69cbe
Showing 1 changed file with 10 additions and 2 deletions.
Expand Up @@ -28,6 +28,14 @@

using namespace __sanitizer;

#if SANITIZER_SOLARIS && defined(__sparcv9)
// FIXME: These tests probably fail because Solaris/sparcv9 uses the full
// 64-bit address space. Needs more investigation
#define SKIP_ON_SOLARIS_SPARCV9(x) DISABLED_##x
#else
#define SKIP_ON_SOLARIS_SPARCV9(x) x
#endif

// Too slow for debug build
#if !SANITIZER_DEBUG

Expand Down Expand Up @@ -701,7 +709,7 @@ TEST(SanitizerCommon, CombinedAllocator64VeryCompact) {
}
#endif

TEST(SanitizerCommon, CombinedAllocator32Compact) {
TEST(SanitizerCommon, SKIP_ON_SOLARIS_SPARCV9(CombinedAllocator32Compact)) {
TestCombinedAllocator<Allocator32Compact>();
}

Expand Down Expand Up @@ -937,7 +945,7 @@ TEST(SanitizerCommon, SizeClassAllocator64DynamicIteration) {
#endif
#endif

TEST(SanitizerCommon, SizeClassAllocator32Iteration) {
TEST(SanitizerCommon, SKIP_ON_SOLARIS_SPARCV9(SizeClassAllocator32Iteration)) {
TestSizeClassAllocatorIteration<Allocator32Compact>();
}

Expand Down

0 comments on commit 0f69cbe

Please sign in to comment.