Skip to content

Commit

Permalink
[clangd] Get rid of raw string literals in macro calls
Browse files Browse the repository at this point in the history
  • Loading branch information
kadircet committed Dec 16, 2019
1 parent 64678ef commit 0f959c8
Showing 1 changed file with 21 additions and 12 deletions.
33 changes: 21 additions & 12 deletions clang-tools-extra/clangd/unittests/FormattedStringTests.cpp
Expand Up @@ -102,17 +102,17 @@ TEST(Paragraph, ExtraSpaces) {
Paragraph P;
P.appendText("foo\n \t baz");
P.appendCode(" bar\n");
EXPECT_EQ(P.asMarkdown(), R"md(foo baz `bar`)md");
EXPECT_EQ(P.asPlainText(), R"pt(foo baz bar)pt");
EXPECT_EQ(P.asMarkdown(), "foo baz `bar`");
EXPECT_EQ(P.asPlainText(), "foo baz bar");
}

TEST(Paragraph, NewLines) {
// New lines before and after chunks are dropped.
Paragraph P;
P.appendText(" \n foo\nbar\n ");
P.appendCode(" \n foo\nbar \n ");
EXPECT_EQ(P.asMarkdown(), R"md(foo bar `foo bar`)md");
EXPECT_EQ(P.asPlainText(), R"pt(foo bar foo bar)pt");
EXPECT_EQ(P.asMarkdown(), "foo bar `foo bar`");
EXPECT_EQ(P.asPlainText(), "foo bar foo bar");
}

TEST(Document, Separators) {
Expand Down Expand Up @@ -149,32 +149,41 @@ TEST(CodeBlock, Render) {
Document D;
// Code blocks preserves any extra spaces.
D.addCodeBlock("foo\n bar\n baz");
EXPECT_EQ(D.asMarkdown(), R"md(```cpp

llvm::StringRef ExpectedMarkdown =
R"md(```cpp
foo
bar
baz
```)md");
EXPECT_EQ(D.asPlainText(), R"pt(foo
```)md";
llvm::StringRef ExpectedPlainText =
R"pt(foo
bar
baz)pt");
baz)pt";
EXPECT_EQ(D.asMarkdown(), ExpectedMarkdown);
EXPECT_EQ(D.asPlainText(), ExpectedPlainText);
D.addCodeBlock("foo");
EXPECT_EQ(D.asMarkdown(), R"md(```cpp
ExpectedMarkdown =
R"md(```cpp
foo
bar
baz
```
```cpp
foo
```)md");
```)md";
EXPECT_EQ(D.asMarkdown(), ExpectedMarkdown);
// FIXME: we shouldn't have 2 empty lines in between. A solution might be
// having a `verticalMargin` method for blocks, and let container insert new
// lines according to that before/after blocks.
EXPECT_EQ(D.asPlainText(), R"pt(foo
ExpectedPlainText =
R"pt(foo
bar
baz
foo)pt");
foo)pt";
EXPECT_EQ(D.asPlainText(), ExpectedPlainText);
}

} // namespace
Expand Down

0 comments on commit 0f959c8

Please sign in to comment.