Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Sanitizers][Atos] Remove null-ing of atos process pointer
Currently, when we send an address to atos to be symbolized, it is expected that atos returns with more than it was sent, i.e. symbol information for that address. In the case where only the address is returned, we currently null the pointer to the atos process. Typically, for modules where no symbolication is expected, we do not send the address to atos. However, in new simulators there is an early call that atos does not return any symbol information for. And in this case, because we have gotten rid of the pointer to the process, no subsequent frames are symbolicated, even tho atos is still working/running. This patch removes the nulling of the pointer to the process. This allows subsequent calls to atos even after an unexpected result. It also now Reports what has happened and the address this occurred. This will improve symbolication in cases where we get an unepxected result, and will make it easier to diagnose atos if it is not symbolicating as expected. Filed a radar about the change of behavior 107621524 rdar://107169715 Differential Revision: https://reviews.llvm.org/D147725
- Loading branch information