[ELF] Simplify --fortran-common. NFC

llvm · Feb 24, 2022 · 15617cd · 15617cd
1 parent 4129890
commit 15617cd
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
@@ -653,15 +653,12 @@ void Symbol::resolveDefined(const Defined &other) {
 void Symbol::resolveLazy(const LazyObject &other) {
   // For common objects, we want to look for global or weak definitions that
   // should be extracted as the canonical definition instead.
-  if (isCommon() && elf::config->fortranCommon) {
-    if (auto *loSym = dyn_cast<LazyObject>(&other)) {
-      if (loSym->file->shouldExtractForCommon(getName())) {
-        backwardReferences.erase(this);
-        replace(other);
-        other.extract();
-        return;
-      }
-    }
+  if (LLVM_UNLIKELY(isCommon()) && elf::config->fortranCommon &&
+      other.file->shouldExtractForCommon(getName())) {
+    backwardReferences.erase(this);
+    replace(other);
+    other.extract();
+    return;
   }
 
   if (!isUndefined()) {