Skip to content

Commit

Permalink
RegisterCoalescer: Remove dubious dropping of implicit virtual regist…
Browse files Browse the repository at this point in the history
…er defs

Don't understand why this would either be OK or necessary, but doesn't
appear to happen in any tests. This was introduced way back in
76e66c3

https://reviews.llvm.org/D156265
  • Loading branch information
arsenm committed Jul 31, 2023
1 parent 02a0b11 commit 161c0d5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions llvm/lib/CodeGen/RegisterCoalescer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1396,9 +1396,8 @@ bool RegisterCoalescer::reMaterializeTrivialDef(const CoalescerPair &CP,
MachineOperand &MO = CopyMI->getOperand(I);
if (MO.isReg()) {
assert(MO.isImplicit() && "No explicit operands after implicit operands.");
// Discard VReg implicit defs.
if (MO.getReg().isPhysical())
ImplicitOps.push_back(MO);
assert(MO.getReg().isPhysical() && "unexpected implicit virtual register def");
ImplicitOps.push_back(MO);
}
}

Expand Down

0 comments on commit 161c0d5

Please sign in to comment.