Skip to content

Commit

Permalink
[lldb] [gdb-remote] Fix processing generic regnums
Browse files Browse the repository at this point in the history
Fix regression in processing generic regnums that was introduced
in fa45650 ("[lldb] [gdb-remote]
Refactor getting remote regs to use local vector").  Since then,
the "generic" field was wrongly interpreted as integer rather than
string constant.

Thanks to Ted Woodward for noticing and providing the correct code.
  • Loading branch information
mgorny committed Oct 29, 2021
1 parent 5caad9b commit 16a816a
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -492,7 +492,7 @@ void ProcessGDBRemote::BuildDynamicRegisterInfo(bool force) {
} else if (name.equals("dwarf")) {
value.getAsInteger(0, reg_info.regnum_dwarf);
} else if (name.equals("generic")) {
value.getAsInteger(0, reg_info.regnum_generic);
reg_info.regnum_generic = Args::StringToGenericRegister(value);
} else if (name.equals("container-regs")) {
SplitCommaSeparatedRegisterNumberString(value, reg_info.value_regs, 16);
} else if (name.equals("invalidate-regs")) {
Expand Down

0 comments on commit 16a816a

Please sign in to comment.