Skip to content

Commit

Permalink
[Clang] Fill in documentation gaps for some attributes (#68967)
Browse files Browse the repository at this point in the history
This patch adds some missing documentation for some attributes in
BitCodeFormat, where the integer code mappings for attributes after code
79 were not listed, and in LangRef where the incompatibility between
minsize/optsize and optnone was not mentioned.
  • Loading branch information
SLTozer committed Oct 18, 2023
1 parent b0b8e83 commit 178619d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions llvm/docs/BitCodeFormat.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1085,6 +1085,14 @@ The integer codes are mapped to well-known attributes as follows.
* code 77: ``elementtype``
* code 78: ``disable_sanitizer_instrumentation``
* code 79: ``nosanitize_bounds``
* code 80: ``allocalign``
* code 81: ``allocptr``
* code 82: ``allockind``
* code 83: ``presplitcoroutine``
* code 84: ``fn_ret_thunk_extern``
* code 85: ``skipprofile``
* code 86: ``memory``
* code 87: ``nofpclass``

.. note::
The ``allocsize`` attribute has a special encoding for its arguments. Its two
Expand Down
2 changes: 2 additions & 0 deletions llvm/docs/LangRef.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1872,6 +1872,7 @@ example:
passes make choices that keep the code size of this function as small
as possible and perform optimizations that may sacrifice runtime
performance in order to minimize the size of the generated code.
This attribute is incompatible with the ``optnone`` attribute.
``naked``
This attribute disables prologue / epilogue emission for the
function. This can have very system-specific consequences.
Expand Down Expand Up @@ -2044,6 +2045,7 @@ example:
passes make choices that keep the code size of this function low,
and otherwise do optimizations specifically to reduce code size as
long as they do not significantly impact runtime performance.
This attribute is incompatible with the ``optnone`` attribute.
``"patchable-function"``
This attribute tells the code generator that the code
generated for this function needs to follow certain conventions that
Expand Down

0 comments on commit 178619d

Please sign in to comment.