Skip to content

Commit

Permalink
[libc] Fix dependency to unit tests, and quitting in non-GPU mode
Browse files Browse the repository at this point in the history
Summary:
Fixes the lack of a dependency after changing the order of some
includes. Also we weren't running any tests as the GPU was always
disabling them. Fix the logic.
  • Loading branch information
jhuber6 committed Mar 17, 2023
1 parent 53076d3 commit 179a7f1
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions libc/test/CMakeLists.txt
Expand Up @@ -5,6 +5,10 @@ add_dependencies(check-libc libc-unit-tests)
add_custom_target(exhaustive-check-libc)
add_custom_target(libc-long-running-tests)

if(NOT LIBC_TARGET_ARCHITECTURE_IS_GPU)
add_subdirectory(UnitTest)
endif()

add_header_library(
errno_setter_matcher
HDRS
Expand All @@ -13,13 +17,13 @@ add_header_library(
libc.src.errno.errno
)

if(NOT TARGET libc.utils.gpu.loader OR NOT TARGET libc.startup.gpu.crt1)
if(LIBC_TARGET_ARCHITECTURE_IS_GPU AND
(NOT TARGET libc.utils.gpu.loader OR NOT TARGET libc.startup.gpu.crt1))
message(WARNING "Cannot build libc GPU tests, missing loader implementation")
return()
endif()

if(NOT LIBC_TARGET_ARCHITECTURE_IS_GPU)
add_subdirectory(UnitTest)
add_subdirectory(src)
add_subdirectory(utils)
endif()
Expand Down

0 comments on commit 179a7f1

Please sign in to comment.