Skip to content

Commit

Permalink
Fix a check in the objc trampoline handler
Browse files Browse the repository at this point in the history
Summary:
The function FunctionCaller::WriteFunctionArguments returns false on
errors, so they should check for the false return value.

Change by Walter Erquinigo <a20012251@gmail.com>

Reviewers: jingham, clayborg

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D22278

llvm-svn: 275287
  • Loading branch information
sas committed Jul 13, 2016
1 parent 0e27d67 commit 1852a78
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -818,7 +818,7 @@ AppleObjCTrampolineHandler::SetupDispatchFunction(Thread &thread, ValueList &dis
// if other threads were calling into here, but actually it isn't because we allocate a new args structure for
// this call by passing args_addr = LLDB_INVALID_ADDRESS...

if (impl_function_caller->WriteFunctionArguments(exe_ctx, args_addr, dispatch_values, diagnostics))
if (!impl_function_caller->WriteFunctionArguments(exe_ctx, args_addr, dispatch_values, diagnostics))
{
if (log)
{
Expand Down

0 comments on commit 1852a78

Please sign in to comment.