Skip to content

Commit

Permalink
[libc] Fix benchmarks build.
Browse files Browse the repository at this point in the history
Reviewers: gchatelet, echristo

Subscribers: mgorny, tschuett, libc-commits

Tags: #libc-project

Differential Revision: https://reviews.llvm.org/D79040
  • Loading branch information
Siva Chandra Reddy committed Apr 28, 2020
1 parent ad38f4b commit 1852af1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions libc/utils/benchmarks/CMakeLists.txt
Expand Up @@ -24,6 +24,7 @@ ExternalProject_Add(google-benchmark
-DCMAKE_C_COMPILER:STRING=${CMAKE_C_COMPILER}
-DCMAKE_CXX_COMPILER:STRING=${CMAKE_CXX_COMPILER}
-DCMAKE_CXX_FLAGS:STRING=${GOOGLE_BENCHMARK_TARGET_FLAGS}
-DCMAKE_CXX_STANDARD:STRING=14
-DCMAKE_BUILD_TYPE:STRING=RELEASE
-DCMAKE_INSTALL_PREFIX:PATH=<INSTALL_DIR>
-DBENCHMARK_ENABLE_TESTING:BOOL=OFF)
Expand Down
4 changes: 3 additions & 1 deletion libc/utils/benchmarks/JSON.cpp
Expand Up @@ -17,9 +17,11 @@
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/JSON.h"
#include "llvm/Support/MathExtras.h"

#include <chrono>
#include <limits>
#include <memory>
#include <string>
#include <vector>

namespace llvm {
Expand Down Expand Up @@ -48,7 +50,7 @@ static Error fromJson(const json::Value &V, double &Out) {

static Error fromJson(const json::Value &V, std::string &Out) {
if (auto S = V.getAsString()) {
Out = *S;
Out = std::string(*S);
return Error::success();
}
return createStringError(errc::io_error, "Can't parse String");
Expand Down
4 changes: 3 additions & 1 deletion libc/utils/benchmarks/LibcMemoryBenchmarkMain.cpp
Expand Up @@ -17,6 +17,8 @@
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/raw_ostream.h"

#include <string>

namespace llvm {
namespace libc_benchmarks {

Expand Down Expand Up @@ -61,7 +63,7 @@ void Main() {
size_t Steps = 0;
for (auto FunctionName : Runner->getFunctionNames()) {
FunctionMeasurements FM;
FM.Name = FunctionName;
FM.Name = std::string(FunctionName);
for (size_t Run = 0; Run < Runs; ++Run) {
for (uint32_t Size = SR.From; Size <= SR.To; Size += SR.Step) {
const auto Result = Runner->benchmark(S.Options, FunctionName, Size);
Expand Down

0 comments on commit 1852af1

Please sign in to comment.