[BOLT][NFC] Remove uses of std::vector<bool>

Summary: LLVM Programmer’s Manual strongly discourages the use of `std::vector<bool>` and suggests `llvm::BitVector` as a possible replacement.
llvm · Jan 14, 2022 · 18bc405 · 18bc405
1 parent dc9f18d
commit 18bc405
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/bolt/include/bolt/Passes/ReorderUtils.h b/bolt/include/bolt/Passes/ReorderUtils.h
@@ -142,7 +142,7 @@ class ClusterPairCacheThreadSafe {
 private:
   size_t Size;
   std::vector<ValueType> Cache;
-  std::vector<bool> Valid;
+  BitVector Valid;
 
   size_t index(const Cluster *First, const Cluster *Second) const {
     return (First->id() * Size) + Second->id();

diff --git a/bolt/include/bolt/Passes/ShrinkWrapping.h b/bolt/include/bolt/Passes/ShrinkWrapping.h
@@ -295,7 +295,7 @@ class ShrinkWrapping {
   /// of moving this Callee-Saved Reg
   DenseMap<unsigned, std::vector<uint32_t>> DeletedPushCFIs;
   DenseMap<unsigned, std::vector<uint32_t>> DeletedPopCFIs;
-  std::vector<bool> HasDeletedOffsetCFIs;
+  BitVector HasDeletedOffsetCFIs;
   SmallPtrSet<const MCCFIInstruction *, 16> UpdatedCFIs;
   std::vector<BitVector> UsesByReg;
   std::vector<int64_t> PushOffsetByReg;

diff --git a/bolt/lib/Passes/ReorderAlgorithm.cpp b/bolt/lib/Passes/ReorderAlgorithm.cpp
@@ -477,7 +477,7 @@ void TSPReorderAlgorithm::reorderBasicBlocks(const BinaryFunction &BF,
   // Define final function layout based on layout that maximizes weight
   uint64_t Last = BestLast;
   uint64_t Set = BestSet;
-  std::vector<bool> Visited;
+  BitVector Visited;
   Visited.resize(N);
   Visited[Last] = true;
   Order.push_back(IndexToBB[Last]);

diff --git a/bolt/lib/Passes/ShrinkWrapping.cpp b/bolt/lib/Passes/ShrinkWrapping.cpp
@@ -1951,7 +1951,7 @@ void ShrinkWrapping::rebuildCFI() {
 }
 
 bool ShrinkWrapping::perform() {
-  HasDeletedOffsetCFIs = std::vector<bool>(BC.MRI->getNumRegs(), false);
+  HasDeletedOffsetCFIs = BitVector(BC.MRI->getNumRegs(), false);
   PushOffsetByReg = std::vector<int64_t>(BC.MRI->getNumRegs(), 0LL);
   PopOffsetByReg = std::vector<int64_t>(BC.MRI->getNumRegs(), 0LL);
   DomOrder = std::vector<MCPhysReg>(BC.MRI->getNumRegs(), 0);