Skip to content

Commit

Permalink
[libc++] Remove the __libcpp_version file
Browse files Browse the repository at this point in the history
It seems to have been added back in 761e42f for Clang to use it,
however it seems to have never been used for that purpose, so it is
probably fine to remove it.

Differential Revision: https://reviews.llvm.org/D122330
  • Loading branch information
ldionne committed Mar 31, 2022
1 parent 33b3c86 commit 19246b0
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 38 deletions.
7 changes: 3 additions & 4 deletions libcxx/docs/Contributing.rst
Expand Up @@ -67,10 +67,9 @@ Post-release check list
After branching for an LLVM release:

1. Update ``_LIBCPP_VERSION`` in ``libcxx/include/__config``
2. Update the ``libcxx/include/__libcpp_version`` file
3. Update the version number in ``libcxx/docs/conf.py``
4. Update ``_LIBCPPABI_VERSION`` in ``libcxxabi/include/cxxabi.h``
5. Update ``_LIBUNWIND_VERSION`` in ``libunwind/include/__libunwind_config.h``
2. Update the version number in ``libcxx/docs/conf.py``
3. Update ``_LIBCPPABI_VERSION`` in ``libcxxabi/include/cxxabi.h``
4. Update ``_LIBUNWIND_VERSION`` in ``libunwind/include/__libunwind_config.h``

Exporting new symbols from the library
======================================
Expand Down
1 change: 0 additions & 1 deletion libcxx/include/CMakeLists.txt
Expand Up @@ -267,7 +267,6 @@ set(files
__iterator/sortable.h
__iterator/unreachable_sentinel.h
__iterator/wrap_iter.h
__libcpp_version
__locale
__mbstate_t.h
__memory/addressof.h
Expand Down
1 change: 0 additions & 1 deletion libcxx/include/__libcpp_version

This file was deleted.

28 changes: 0 additions & 28 deletions libcxx/test/libcxx/libcpp_version.pass.cpp

This file was deleted.

1 change: 0 additions & 1 deletion libcxx/test/libcxx/lint/lint_headers.sh.py
Expand Up @@ -14,7 +14,6 @@ def exclude_from_consideration(path):
path.endswith('.modulemap') or
os.path.basename(path) == '__config' or
os.path.basename(path) == '__config_site.in' or
os.path.basename(path) == '__libcpp_version' or
not os.path.isfile(path)
)

Expand Down
2 changes: 1 addition & 1 deletion libcxx/utils/generate_assertion_tests.py
Expand Up @@ -56,7 +56,7 @@
private_headers_still_public_in_modules = [
'__assert', '__bsd_locale_defaults.h', '__bsd_locale_fallbacks.h', '__config',
'__config_site.in', '__debug', '__hash_table',
'__libcpp_version', '__threading_support', '__tree', '__undef_macros'
'__threading_support', '__tree', '__undef_macros'
]

def find_script(file):
Expand Down
2 changes: 1 addition & 1 deletion libcxx/utils/generate_private_header_tests.py
Expand Up @@ -54,7 +54,7 @@ def is_still_public(path):
return not rp.startswith('__support') and rp not in [
"__assert", "__bsd_locale_defaults.h", "__bsd_locale_fallbacks.h", "__config",
"__config_site.in", "__debug", "__hash_table",
"__libcpp_version", "__threading_support", "__tree", "__undef_macros"
"__threading_support", "__tree", "__undef_macros"
]


Expand Down
2 changes: 1 addition & 1 deletion libcxx/utils/graph_header_deps.py
Expand Up @@ -14,7 +14,7 @@


def is_config_header(h):
return os.path.basename(h) in ['__config', '__libcpp_version', '__undef_macros', 'version']
return os.path.basename(h) in ['__config', '__undef_macros', 'version']


def is_experimental_header(h):
Expand Down

0 comments on commit 19246b0

Please sign in to comment.