Skip to content

Commit

Permalink
[NFC] [C++20] [Coroutines] Mention the side effect of a fix may bring…
Browse files Browse the repository at this point in the history
… regressions

The fix we sent for #56301
may bring performance regressions. But we didn't mention it in the
ReleaseNotes so that users may get confused. e.g,
#64933. So this patch
mentions the possible side effect and the potential solutions in
#64945 to avoid
misunderstandings.
  • Loading branch information
ChuanqiXu9 committed Aug 24, 2023
1 parent bb6073c commit 19ab266
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions clang/docs/ReleaseNotes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ Bug Fixes in This Version
``await_suspend`` could be misoptimized, including accesses to the awaiter
object itself.
(`#56301 <https://github.com/llvm/llvm-project/issues/56301>`_)
The current solution may bring performance regressions if the awaiters have
non-static data members. See
`#64945 <https://github.com/llvm/llvm-project/issues/64945>`_ for details.

Bug Fixes to Compiler Builtins
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down

0 comments on commit 19ab266

Please sign in to comment.